diff options
| author | rafaelw@chromium.org <rafaelw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-24 00:19:54 +0000 |
|---|---|---|
| committer | rafaelw@chromium.org <rafaelw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-24 00:19:54 +0000 |
| commit | 66bd33dbf76732655a7d5b156b895e78274ea1bc (patch) | |
| tree | 79c13921ae5b0f3a5e6e56bdba73fe5402453e56 /chrome/browser/options_page_base.cc | |
| parent | 489853ce6239d4333923c6f4d7a1d6ae0284fe88 (diff) | |
| download | chromium_src-66bd33dbf76732655a7d5b156b895e78274ea1bc.zip chromium_src-66bd33dbf76732655a7d5b156b895e78274ea1bc.tar.gz chromium_src-66bd33dbf76732655a7d5b156b895e78274ea1bc.tar.bz2 | |
Fix crash when an extension popup shows a JS alert. Showing the alert takes...
Landing this on for pam. Original issue: http://codereview.chromium.org/425011/show.
Disable showing JS alerts from popups, because doing so makes the popup
disappear immediately, which has all sorts of unfortunate side effects for the
poor orphaned alert (see bug for details).
BUG=27758
TEST=create extension with popup, put link with |onclick="alert('test');"| in
it; install extension, open popup, and click link; see no crash (nor popup)
Review URL: http://codereview.chromium.org/435010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32889 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/options_page_base.cc')
0 files changed, 0 insertions, 0 deletions