diff options
author | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-25 10:40:25 +0000 |
---|---|---|
committer | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-25 10:40:25 +0000 |
commit | 34041bbb342fbd063e378e65482ac32647be3ca2 (patch) | |
tree | cbc7d6660d2778eaf9416d797fed427eb5c79a5a /chrome/browser/page_info_model.h | |
parent | 2cb83c853036f789735e17b33d7bfb9805dbfa9f (diff) | |
download | chromium_src-34041bbb342fbd063e378e65482ac32647be3ca2.zip chromium_src-34041bbb342fbd063e378e65482ac32647be3ca2.tar.gz chromium_src-34041bbb342fbd063e378e65482ac32647be3ca2.tar.bz2 |
Revert 57311 - Part 2 of the SSL InfoBubble.
- Added Certificate Information link.
- Changed iconography to be:
Identity : Green check mark vs. Red skull and bones
Connection: Green padlock vs. Orange exclamation point.
(This used to be Green checkmark and Orange Exclamation point for both sections.
- Removed the icon for the First visit section. Need to see if we want an icon for when you haven't visited the site before. Mocks show no icons when you have visited before.
BUG=52916
TEST=Open the SSL InfoBubble and notice the new iconography. Click the link and the Certificate dialog should show.
Review URL: http://codereview.chromium.org/3136031
TBR=finnur@chromium.org
Review URL: http://codereview.chromium.org/3170043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57314 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/page_info_model.h')
-rw-r--r-- | chrome/browser/page_info_model.h | 24 |
1 files changed, 6 insertions, 18 deletions
diff --git a/chrome/browser/page_info_model.h b/chrome/browser/page_info_model.h index 60e3883..6bf0389 100644 --- a/chrome/browser/page_info_model.h +++ b/chrome/browser/page_info_model.h @@ -18,7 +18,7 @@ class PrefService; class Profile; // The model that provides the information that should be displayed in the page -// info dialog/bubble. +// info dialog. class PageInfoModel { public: class PageInfoModelObserver { @@ -29,23 +29,15 @@ class PageInfoModel { virtual ~PageInfoModelObserver() {} }; - enum SectionInfoType { - SECTION_INFO_IDENTITY = 0, - SECTION_INFO_CONNECTION, - SECTION_INFO_FIRST_VISIT, - }; - struct SectionInfo { SectionInfo(bool state, const string16& title, - const string16& headline, - const string16& description, - SectionInfoType type) + const string16& head_line, + const string16& description) : state(state), title(title), - headline(headline), - description(description), - type(type) { + head_line(head_line), + description(description) { } bool state; // True if state is OK, false otherwise (ex of bad states: @@ -55,14 +47,10 @@ class PageInfoModel { string16 title; // A single line describing the section, optional. - string16 headline; + string16 head_line; // The full description of what this section is. string16 description; - - // The type of SectionInfo we are dealing with, for example: Identity, - // Connection, First Visit. - SectionInfoType type; }; PageInfoModel(Profile* profile, |