summaryrefslogtreecommitdiffstats
path: root/chrome/browser/page_menu_model_unittest.cc
diff options
context:
space:
mode:
authormattm@chromium.org <mattm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-04-09 00:23:00 +0000
committermattm@chromium.org <mattm@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2010-04-09 00:23:00 +0000
commit2bfc319546d3cd8d2611f22a5cf58e1996ea8ec9 (patch)
tree5e65d2fefd0701e7ee02354966318eb7cfc2742a /chrome/browser/page_menu_model_unittest.cc
parent2e0b84e7d2a676a706f99a796718a7c2171165d5 (diff)
downloadchromium_src-2bfc319546d3cd8d2611f22a5cf58e1996ea8ec9.zip
chromium_src-2bfc319546d3cd8d2611f22a5cf58e1996ea8ec9.tar.gz
chromium_src-2bfc319546d3cd8d2611f22a5cf58e1996ea8ec9.tar.bz2
Tentative fix for crash in EncodingMenuController::IsItemChecked.
BUG=36180 TEST=unittest Review URL: http://codereview.chromium.org/1591026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44033 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/page_menu_model_unittest.cc')
-rw-r--r--chrome/browser/page_menu_model_unittest.cc17
1 files changed, 14 insertions, 3 deletions
diff --git a/chrome/browser/page_menu_model_unittest.cc b/chrome/browser/page_menu_model_unittest.cc
index 9c38b0b..98f1e3f 100644
--- a/chrome/browser/page_menu_model_unittest.cc
+++ b/chrome/browser/page_menu_model_unittest.cc
@@ -1,10 +1,11 @@
-// Copyright (c) 2009 The Chromium Authors. All rights reserved. Use of this
-// source code is governed by a BSD-style license that can be found in the
-// LICENSE file.
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
#include "chrome/browser/page_menu_model.h"
#include "base/logging.h"
+#include "chrome/app/chrome_dll_resource.h"
#include "chrome/test/browser_with_test_window_test.h"
#include "chrome/test/menu_model_test.h"
#include "grit/generated_resources.h"
@@ -54,3 +55,13 @@ TEST_F(PageMenuModelTest, Basics) {
EXPECT_EQ(delegate_.execute_count_, 1);
EXPECT_EQ(delegate_.enable_count_, 1);
}
+
+class EncodingMenuModelTest : public BrowserWithTestWindowTest,
+ public MenuModelTest {
+};
+
+TEST_F(EncodingMenuModelTest, IsCommandIdCheckedWithNoTabs) {
+ EncodingMenuModel model(browser());
+ ASSERT_EQ(NULL, browser()->GetSelectedTabContents());
+ EXPECT_FALSE(model.IsCommandIdChecked(IDC_ENCODING_ISO88591));
+}