diff options
author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-30 19:28:44 +0000 |
---|---|---|
committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-30 19:28:44 +0000 |
commit | 528c56de01bbbd38788ed6cf8d2eea4c56cbe19e (patch) | |
tree | ac4f7a001affd772c4ab89701d3d46109b5f9e19 /chrome/browser/page_state.cc | |
parent | 5c86ada8d84f6e67d17b027d347052ef451241c4 (diff) | |
download | chromium_src-528c56de01bbbd38788ed6cf8d2eea4c56cbe19e.zip chromium_src-528c56de01bbbd38788ed6cf8d2eea4c56cbe19e.tar.gz chromium_src-528c56de01bbbd38788ed6cf8d2eea4c56cbe19e.tar.bz2 |
Move the number conversions from string_util to a new file.
Use the base namespace in the new file. Update callers.
I removed all wstring variants and also the string->number ones that ignore the return value. That encourages people to write code and forget about error handling.
TEST=included unit tests
BUG=none
Review URL: http://codereview.chromium.org/3056029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54355 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/page_state.cc')
-rw-r--r-- | chrome/browser/page_state.cc | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/chrome/browser/page_state.cc b/chrome/browser/page_state.cc index bf431ca..19764f0 100644 --- a/chrome/browser/page_state.cc +++ b/chrome/browser/page_state.cc @@ -6,7 +6,7 @@ #include "base/basictypes.h" #include "base/logging.h" -#include "base/string_util.h" +#include "base/string_number_conversions.h" #include "base/utf_string_conversions.h" #include "chrome/browser/page_state.h" #include "chrome/common/json_value_serializer.h" @@ -80,25 +80,25 @@ bool PageState::GetProperty(const std::wstring& key, } void PageState::SetInt64Property(const std::wstring& key, int64 value) { - SetProperty(key, Int64ToWString(value)); + SetProperty(key, UTF8ToWide(base::Int64ToString(value))); } bool PageState::GetInt64Property(const std::wstring& key, int64* value) const { std::wstring v; if (GetProperty(key, &v)) { - return StringToInt64(WideToUTF16Hack(v), value); + return base::StringToInt64(WideToUTF8(v), value); } return false; } void PageState::SetIntProperty(const std::wstring& key, int value) { - SetProperty(key, IntToWString(value)); + SetProperty(key, UTF8ToWide(base::IntToString(value))); } bool PageState::GetIntProperty(const std::wstring& key, int* value) const { std::wstring v; if (GetProperty(key, &v)) { - return StringToInt(WideToUTF16Hack(v), value); + return base::StringToInt(WideToUTF8(v), value); } return false; } |