diff options
author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-02-02 05:12:33 +0000 |
---|---|---|
committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-02-02 05:12:33 +0000 |
commit | a3ef4830d5b5fdc52e5d7d0cb33dae8844f0961e (patch) | |
tree | bdd4dac76e6034ef6cf33450e203269a715ea0e6 /chrome/browser/parsers | |
parent | 8bc574c57115e9ffd0169f33131c0865997dcb35 (diff) | |
download | chromium_src-a3ef4830d5b5fdc52e5d7d0cb33dae8844f0961e.zip chromium_src-a3ef4830d5b5fdc52e5d7d0cb33dae8844f0961e.tar.gz chromium_src-a3ef4830d5b5fdc52e5d7d0cb33dae8844f0961e.tar.bz2 |
Add FilePath to base namespace.
This updates headers that forward-declare it and a few random places to use the namespace explicitly. There us a using declaration in file_path.h that makes the rest compile, which we can do in future passes.
Review URL: https://codereview.chromium.org/12163003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180245 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/parsers')
4 files changed, 16 insertions, 7 deletions
diff --git a/chrome/browser/parsers/metadata_parser.h b/chrome/browser/parsers/metadata_parser.h index 6700d14..8034a36 100644 --- a/chrome/browser/parsers/metadata_parser.h +++ b/chrome/browser/parsers/metadata_parser.h @@ -7,7 +7,9 @@ #include <string> +namespace base { class FilePath; +} // Allows for Iteration on the Properties of a given file. class MetadataPropertyIterator { @@ -30,7 +32,7 @@ class MetadataPropertyIterator { // Represents a single instance of parsing on a particular file. class MetadataParser { public: - explicit MetadataParser(const FilePath& path) {} + explicit MetadataParser(const base::FilePath& path) {} virtual ~MetadataParser() {} diff --git a/chrome/browser/parsers/metadata_parser_factory.h b/chrome/browser/parsers/metadata_parser_factory.h index d1d1279..c6c5a26 100644 --- a/chrome/browser/parsers/metadata_parser_factory.h +++ b/chrome/browser/parsers/metadata_parser_factory.h @@ -7,7 +7,9 @@ #include "chrome/browser/parsers/metadata_parser.h" +namespace base { class FilePath; +} // Used to check to see if a parser can parse a particular file, and allows // for creation of a parser on a particular file. @@ -18,13 +20,13 @@ class MetadataParserFactory { // Used to check to see if the parser can parse the given file. This // should not do any additional reading of the file. - virtual bool CanParse(const FilePath& path, + virtual bool CanParse(const base::FilePath& path, char* bytes, int bytes_size) = 0; // Creates the parser on the given file. Creating the parser does not // do any parsing on the file. Parse has to be called on the parser. - virtual MetadataParser* CreateParser(const FilePath& path) = 0; + virtual MetadataParser* CreateParser(const base::FilePath& path) = 0; }; #endif // CHROME_BROWSER_PARSERS_METADATA_PARSER_FACTORY_H_ diff --git a/chrome/browser/parsers/metadata_parser_jpeg_factory.h b/chrome/browser/parsers/metadata_parser_jpeg_factory.h index 705f964d5..1c21144 100644 --- a/chrome/browser/parsers/metadata_parser_jpeg_factory.h +++ b/chrome/browser/parsers/metadata_parser_jpeg_factory.h @@ -9,17 +9,19 @@ #include "base/compiler_specific.h" #include "chrome/browser/parsers/metadata_parser_factory.h" +namespace base { class FilePath; +} class MetadataParserJpegFactory : public MetadataParserFactory { public: MetadataParserJpegFactory(); // Implementation of MetadataParserFactory - virtual bool CanParse(const FilePath& path, + virtual bool CanParse(const base::FilePath& path, char* bytes, int bytes_size) OVERRIDE; - virtual MetadataParser* CreateParser(const FilePath& path) OVERRIDE; + virtual MetadataParser* CreateParser(const base::FilePath& path) OVERRIDE; private: DISALLOW_COPY_AND_ASSIGN(MetadataParserJpegFactory); diff --git a/chrome/browser/parsers/metadata_parser_manager.h b/chrome/browser/parsers/metadata_parser_manager.h index 910629f..2d5a759 100644 --- a/chrome/browser/parsers/metadata_parser_manager.h +++ b/chrome/browser/parsers/metadata_parser_manager.h @@ -9,9 +9,12 @@ #include "base/memory/scoped_vector.h" class MetadataParserFactory; -class FilePath; class MetadataParser; +namespace base { +class FilePath; +} + // Metadata Parser manager is used to find the correct parser for a // given file. Allows parsers to register themselves. class MetadataParserManager { @@ -28,7 +31,7 @@ class MetadataParserManager { bool RegisterParserFactory(MetadataParserFactory* parser); // Returns a new metadata parser for a given file. - MetadataParser* GetParserForFile(const FilePath& path); + MetadataParser* GetParserForFile(const base::FilePath& path); private: ScopedVector<MetadataParserFactory> factories_; |