diff options
| author | estade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-28 20:41:10 +0000 |
|---|---|---|
| committer | estade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-28 20:41:10 +0000 |
| commit | be952c3ca6d93968409b246c9439a7d8c2a06bba (patch) | |
| tree | 501d38ada79c1fddf10f65fe6c88b27a3df4cb1d /chrome/browser/parsers | |
| parent | 86c008e8a7da9c00c5a676eb201ba5d0c976748e (diff) | |
| download | chromium_src-be952c3ca6d93968409b246c9439a7d8c2a06bba.zip chromium_src-be952c3ca6d93968409b246c9439a7d8c2a06bba.tar.gz chromium_src-be952c3ca6d93968409b246c9439a7d8c2a06bba.tar.bz2 | |
Fix a ton of compiler warnings.
Most of these are classes with virtual methods lacking virtual destructors
or NULL used in non-pointer context.
BUG=none
TEST=app_unittests && base_unittests
--gtest_filter=-ConditionVariableTest.LargeFastTaskTest
patch by Jacob Mandelson <jlmjlm [at] gmail>
http://codereview.chromium.org/171028/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24792 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/parsers')
4 files changed, 8 insertions, 0 deletions
diff --git a/chrome/browser/parsers/metadata_parser.h b/chrome/browser/parsers/metadata_parser.h index 97a4e85..9a8d80d 100644 --- a/chrome/browser/parsers/metadata_parser.h +++ b/chrome/browser/parsers/metadata_parser.h @@ -13,6 +13,7 @@ class MetadataPropertyIterator { public: MetadataPropertyIterator() {} + virtual ~MetadataPropertyIterator() {} // Gets the next Property in the iterator. Returns false if at the end // of the list. @@ -29,6 +30,7 @@ class MetadataPropertyIterator { class MetadataParser { public: MetadataParser(const FilePath& path) {} + virtual ~MetadataParser() {} static const char* kPropertyType; static const char* kPropertyFilesize; diff --git a/chrome/browser/parsers/metadata_parser_factory.h b/chrome/browser/parsers/metadata_parser_factory.h index c42e01d..9c291c4 100644 --- a/chrome/browser/parsers/metadata_parser_factory.h +++ b/chrome/browser/parsers/metadata_parser_factory.h @@ -12,6 +12,7 @@ class MetadataParserFactory { public: MetadataParserFactory() {} + virtual ~MetadataParserFactory() {} // Used to check to see if the parser can parse the given file. This // should not do any additional reading of the file. diff --git a/chrome/browser/parsers/metadata_parser_jpeg_factory.cc b/chrome/browser/parsers/metadata_parser_jpeg_factory.cc index e49cbcb..e79d969 100644 --- a/chrome/browser/parsers/metadata_parser_jpeg_factory.cc +++ b/chrome/browser/parsers/metadata_parser_jpeg_factory.cc @@ -11,6 +11,8 @@ MetadataParserJpegFactory::MetadataParserJpegFactory() : MetadataParserFactory(){} +MetadataParserJpegFactory::~MetadataParserJpegFactory() {} + bool MetadataParserJpegFactory::CanParse(const FilePath& path, char* bytes, int bytes_size) { diff --git a/chrome/browser/parsers/metadata_parser_jpeg_factory.h b/chrome/browser/parsers/metadata_parser_jpeg_factory.h index 48c059b..68399fe 100644 --- a/chrome/browser/parsers/metadata_parser_jpeg_factory.h +++ b/chrome/browser/parsers/metadata_parser_jpeg_factory.h @@ -15,6 +15,9 @@ class MetadataParserJpegFactory : public MetadataParserFactory { virtual bool CanParse(const FilePath& path, char* bytes, int bytes_size); virtual MetadataParser* CreateParser(const FilePath& path); + protected: + ~MetadataParserJpegFactory(); + private: DISALLOW_COPY_AND_ASSIGN(MetadataParserJpegFactory); }; |