RefCounted types should not have public destructors, chrome/browser/ part 5

BUG=123295
TEST=none


Review URL: http://codereview.chromium.org/10068036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133870 0039d316-1c4b-4281-b951-d872f2087c98

5 files changed, 11 insertions, 3 deletions

diff --git a/chrome/browser/password_manager/mock_password_store.cc b/chrome/browser/password_manager/mock_password_store.cc
index 087ad83..ad7f753 100644
--- a/chrome/browser/password_manager/mock_password_store.cc
+++ b/chrome/browser/password_manager/mock_password_store.cc
@@ -6,8 +6,6 @@
 
 MockPasswordStore::MockPasswordStore() {}
 
-MockPasswordStore::~MockPasswordStore() {}
-
 // static
 scoped_refptr<RefcountedProfileKeyedService> MockPasswordStore::Build(
     Profile* profile) {
@@ -15,3 +13,5 @@ scoped_refptr<RefcountedProfileKeyedService> MockPasswordStore::Build(
 }
 
 void MockPasswordStore::ShutdownOnUIThread() {}
+
+MockPasswordStore::~MockPasswordStore() {}
diff --git a/chrome/browser/password_manager/mock_password_store.h b/chrome/browser/password_manager/mock_password_store.h
index 5a13964..627b5db 100644
--- a/chrome/browser/password_manager/mock_password_store.h
+++ b/chrome/browser/password_manager/mock_password_store.h
@@ -14,7 +14,6 @@ class Profile;
 class MockPasswordStore : public PasswordStore {
  public:
   MockPasswordStore();
-  virtual ~MockPasswordStore();
 
   static scoped_refptr<RefcountedProfileKeyedService> Build(Profile* profile);
 
@@ -40,6 +39,9 @@ class MockPasswordStore : public PasswordStore {
       bool(std::vector<webkit::forms::PasswordForm*>*));
 
   virtual void ShutdownOnUIThread();
+
+ private:
+  virtual ~MockPasswordStore();
 };
 
 #endif  // CHROME_BROWSER_PASSWORD_MANAGER_MOCK_PASSWORD_STORE_H_
diff --git a/chrome/browser/password_manager/password_manager.h b/chrome/browser/password_manager/password_manager.h
index 86dba4e..c3f86ac 100644
--- a/chrome/browser/password_manager/password_manager.h
+++ b/chrome/browser/password_manager/password_manager.h
@@ -35,6 +35,7 @@ class PasswordManager : public LoginModel,
   // The delegate passed in is required to outlive the PasswordManager.
   PasswordManager(content::WebContents* web_contents,
                   PasswordManagerDelegate* delegate);
+
   virtual ~PasswordManager();
 
   // Is password autofill enabled for the current profile?
diff --git a/chrome/browser/password_manager/password_store.h b/chrome/browser/password_manager/password_store.h
index acb4a31..eaab997 100644
--- a/chrome/browser/password_manager/password_store.h
+++ b/chrome/browser/password_manager/password_store.h
@@ -62,6 +62,8 @@ class PasswordStore
                                   std::vector<webkit::forms::PasswordForm*> > {
    public:
     explicit GetLoginsRequest(const GetLoginsCallback& callback);
+
+   protected:
     virtual ~GetLoginsRequest();
 
    private:
diff --git a/chrome/browser/password_manager/password_store_win.cc b/chrome/browser/password_manager/password_store_win.cc
index 6a4cbf7..faea2d3 100644
--- a/chrome/browser/password_manager/password_store_win.cc
+++ b/chrome/browser/password_manager/password_store_win.cc
@@ -39,6 +39,9 @@ class FormGetLoginsRequest : public PasswordStore::GetLoginsRequest {
   }
   bool IsLoginsRequest() const { return !!form_.get(); }
 
+ protected:
+  virtual ~FormGetLoginsRequest() {}
+
  private:
   scoped_ptr<PasswordForm> form_;
 };