diff options
| author | maruel@chromium.org <maruel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-02-12 19:49:04 +0000 |
|---|---|---|
| committer | maruel@chromium.org <maruel@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-02-12 19:49:04 +0000 |
| commit | b94d3327ed86b1345ceca7806ae1e050055e252b (patch) | |
| tree | a5fce8db5729299807c8ac0d3bf37e721b535392 /chrome/browser/password_manager | |
| parent | 35b7041fbb49843f868c34ed3b5200d7653a6f5d (diff) | |
| download | chromium_src-b94d3327ed86b1345ceca7806ae1e050055e252b.zip chromium_src-b94d3327ed86b1345ceca7806ae1e050055e252b.tar.gz chromium_src-b94d3327ed86b1345ceca7806ae1e050055e252b.tar.bz2 | |
Lots of small nits to help to split off webkit.dll.
- Stop directly referencing WebPluginDelegateImpl.
- Make the password manager to not allocation the data on heap.
- Remove some unneeded includes.
Review URL: http://codereview.chromium.org/20208
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9692 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/password_manager')
| -rw-r--r-- | chrome/browser/password_manager/password_manager.cc | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/chrome/browser/password_manager/password_manager.cc b/chrome/browser/password_manager/password_manager.cc index 28b83db..4769f07 100644 --- a/chrome/browser/password_manager/password_manager.cc +++ b/chrome/browser/password_manager/password_manager.cc @@ -228,11 +228,12 @@ void PasswordManager::Autofill(const PasswordForm& form_for_autofill, // schemed password form may have been freed, so we need to distinguish. bool action_mismatch = form_for_autofill.action.GetWithEmptyPath() != preferred_match->action.GetWithEmptyPath(); - scoped_ptr<PasswordFormDomManager::FillData> fill_data( - PasswordFormDomManager::CreateFillData(form_for_autofill, - best_matches, preferred_match, - action_mismatch)); - web_contents_->render_view_host()->FillPasswordForm(*fill_data); + PasswordFormDomManager::FillData fill_data; + PasswordFormDomManager::InitFillData(form_for_autofill, + best_matches, preferred_match, + action_mismatch, + &fill_data); + web_contents_->render_view_host()->FillPasswordForm(fill_data); return; } default: |