Preventing our default handlers for ChromeOS to show up or confuse the user

BUG=123368
TEST=None


Review URL: http://codereview.chromium.org/10139002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134283 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 9 insertions, 0 deletions

diff --git a/chrome/browser/platform_util_chromeos.cc b/chrome/browser/platform_util_chromeos.cc
index eaebafd..12d0c78 100644
--- a/chrome/browser/platform_util_chromeos.cc
+++ b/chrome/browser/platform_util_chromeos.cc
@@ -55,6 +55,15 @@ void OpenItem(const FilePath& full_path) {
 }
 
 void OpenExternal(const GURL& url) {
+  // This code should be obsolete since we have default handlers in ChromeOS
+  // which should handle this. However - there are two things which make it
+  // necessary to keep it in:
+  // a.) The user might have deleted the default handler in this session.
+  //     In this case we would need to have this in place.
+  // b.) There are several code paths which are not clear if they would call
+  //     this function directly and which would therefore break (e.g.
+  //     "Browser::EmailPageLocation" (to name only one).
+  // As such we should keep this code here.
   if (url.SchemeIs("mailto")) {
     std::string string_url = kGmailComposeUrl;
     string_url.append(url.spec());