diff options
author | saintlou@chromium.org <saintlou@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-08 16:47:40 +0000 |
---|---|---|
committer | saintlou@chromium.org <saintlou@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-08 16:47:40 +0000 |
commit | 899dfcaf3de8aeb7ae84be00c53c554417d7c493 (patch) | |
tree | d7457d0fff991dc26a8c765198c334fd139398ed /chrome/browser/platform_util_chromeos.cc | |
parent | 4548245c966267e9ece8228cca59511e3754e0b8 (diff) | |
download | chromium_src-899dfcaf3de8aeb7ae84be00c53c554417d7c493.zip chromium_src-899dfcaf3de8aeb7ae84be00c53c554417d7c493.tar.gz chromium_src-899dfcaf3de8aeb7ae84be00c53c554417d7c493.tar.bz2 |
Replacing the default handler for mailto and webcal
This CL was reviewed before here: http://codereview.chromium.org/10139002/
I did the change to it as requested by koz past the previous submission (changing the name)
TBR=benwells@chromium.org
BUG=123368
TEST=unit test
Review URL: https://chromiumcodereview.appspot.com/10317019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135849 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/platform_util_chromeos.cc')
-rw-r--r-- | chrome/browser/platform_util_chromeos.cc | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/chrome/browser/platform_util_chromeos.cc b/chrome/browser/platform_util_chromeos.cc index eaebafd..12d0c78 100644 --- a/chrome/browser/platform_util_chromeos.cc +++ b/chrome/browser/platform_util_chromeos.cc @@ -55,6 +55,15 @@ void OpenItem(const FilePath& full_path) { } void OpenExternal(const GURL& url) { + // This code should be obsolete since we have default handlers in ChromeOS + // which should handle this. However - there are two things which make it + // necessary to keep it in: + // a.) The user might have deleted the default handler in this session. + // In this case we would need to have this in place. + // b.) There are several code paths which are not clear if they would call + // this function directly and which would therefore break (e.g. + // "Browser::EmailPageLocation" (to name only one). + // As such we should keep this code here. if (url.SchemeIs("mailto")) { std::string string_url = kGmailComposeUrl; string_url.append(url.spec()); |