diff options
| author | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-28 16:09:39 +0000 |
|---|---|---|
| committer | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-28 16:09:39 +0000 |
| commit | 4a1665446b3c96006be66b7083511a2eadef6b5e (patch) | |
| tree | c26f796a595058bb57f0818e003dece2494c1714 /chrome/browser/platform_util_chromeos.cc | |
| parent | aeacd285cabfb269ba52fdbb1f60a6bf1e2d94d6 (diff) | |
| download | chromium_src-4a1665446b3c96006be66b7083511a2eadef6b5e.zip chromium_src-4a1665446b3c96006be66b7083511a2eadef6b5e.tar.gz chromium_src-4a1665446b3c96006be66b7083511a2eadef6b5e.tar.bz2 | |
Attempt 2 at Moving Browser::AddTypes to TabStripModel. The first
attempt caused some flakiness on the new tab warm startup test. The
only difference between this and the last is that I'm leaving some
suspcious code in TabStripModel::InsertTabContents and
Browser::AddTabWithURL. I'll try to isolate why those changes caused
flakiness after I land the rest.
Here's the description:
Moves Browser::AddTypes to TabStripModel. This patch is primarily
cleanup before I fix 29933, but has a couple of interesting bits
beyond the enum change:
. AddTabContents now supports adding pinned.
. Converted InsertTabContents call in extensionstabmodule to pass in
nothing (Rafael said old code was wrong).
BUG=29933
TEST=none
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/2866024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50981 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/platform_util_chromeos.cc')
| -rw-r--r-- | chrome/browser/platform_util_chromeos.cc | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/chrome/browser/platform_util_chromeos.cc b/chrome/browser/platform_util_chromeos.cc index 8d18e78..4c0d8cd4 100644 --- a/chrome/browser/platform_util_chromeos.cc +++ b/chrome/browser/platform_util_chromeos.cc @@ -81,8 +81,8 @@ void OpenItem(const FilePath& full_path) { } Browser* browser = BrowserList::GetLastActive(); browser->AddTabWithURL( - GURL(path), GURL(), PageTransition::LINK, -1, Browser::ADD_SELECTED, - NULL, std::string()); + GURL(path), GURL(), PageTransition::LINK, -1, + TabStripModel::ADD_SELECTED, NULL, std::string()); return; } if (ext == ".avi" || @@ -114,8 +114,8 @@ void OpenItem(const FilePath& full_path) { static void OpenURL(const std::string& url) { Browser* browser = BrowserList::GetLastActive(); browser->AddTabWithURL( - GURL(url), GURL(), PageTransition::LINK, -1, Browser::ADD_SELECTED, - NULL, std::string()); + GURL(url), GURL(), PageTransition::LINK, -1, + TabStripModel::ADD_SELECTED, NULL, std::string()); } void OpenExternal(const GURL& url) { |