This changelist fixes some issues with the NPAPI WMP plugin work in Chrome. The first is that we need to disable windowless mode since it doesn't work in the NPAPI plugin (Safari does this as well, and sites don't use windowless for Firefox). The second is to make UpdateGeometry message synchronous for WMP. The problem I saw was that while handling that message, the plugin might disaptch a NPObject Invoke method to play a video, which WMP doesn't expect and it leads to the video never playing.

While touching these files, I made some small cleanup by reverting the change that made WebPluginProxy not have a WebPluginDelegateImpl pointer, which added a bunch of unnecessary methods to WebPluginDelegate.

BUG=20259
TEST=use --no-activex and try playing the videos on http://www.nana10.co.il/Section/?SectionID=10847&sid=235
Review URL: http://codereview.chromium.org/196012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25433 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 1 insertions, 6 deletions

diff --git a/chrome/browser/plugin_service.cc b/chrome/browser/plugin_service.cc
index a3335f1..ac36b16 100644
--- a/chrome/browser/plugin_service.cc
+++ b/chrome/browser/plugin_service.cc
@@ -141,11 +141,6 @@ PluginProcessHost* PluginService::FindOrStartPluginProcess(
   }
 
   return plugin_host;
-
-  // TODO(jabdelmalek): adding a new channel means we can have one less
-  // renderer process (since each child process uses one handle in the
-  // IPC thread and main thread's WaitForMultipleObjects call).  Limit the
-  // number of plugin processes.
 }
 
 void PluginService::OpenChannelToPlugin(
@@ -164,7 +159,7 @@ void PluginService::OpenChannelToPlugin(
   } else {
     PluginProcessHost::ReplyToRenderer(renderer_msg_filter,
                                        IPC::ChannelHandle(),
-                                       FilePath(),
+                                       WebPluginInfo(),
                                        reply_msg);
   }
 }