diff options
author | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-11 03:27:09 +0000 |
---|---|---|
committer | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-11 03:27:09 +0000 |
commit | ef2bf421b04de3134cd7c02aac40a5565ef24dd9 (patch) | |
tree | 5bf90cca0bd015c23e843614ebf2e9f99cb8cd99 /chrome/browser/policy/device_management_service.cc | |
parent | 280e9b5d4b2fb0fe14824e526521710a658bce56 (diff) | |
download | chromium_src-ef2bf421b04de3134cd7c02aac40a5565ef24dd9.zip chromium_src-ef2bf421b04de3134cd7c02aac40a5565ef24dd9.tar.gz chromium_src-ef2bf421b04de3134cd7c02aac40a5565ef24dd9.tar.bz2 |
Stop refcounting URLRequestContext.
While doing so, fix a few issues with the code like ordering of URLRequestContext to ensure correct destruction order. Also fix const correctness in some places.
BUG=58859
TEST=none
TBR=willchan
Review URL: https://chromiumcodereview.appspot.com/10299002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136497 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/policy/device_management_service.cc')
-rw-r--r-- | chrome/browser/policy/device_management_service.cc | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/chrome/browser/policy/device_management_service.cc b/chrome/browser/policy/device_management_service.cc index aab92e1..3e15e96 100644 --- a/chrome/browser/policy/device_management_service.cc +++ b/chrome/browser/policy/device_management_service.cc @@ -186,10 +186,9 @@ const std::string& GetPlatformString() { class DeviceManagementRequestContext : public net::URLRequestContext { public: explicit DeviceManagementRequestContext(net::URLRequestContext* base_context); - - private: virtual ~DeviceManagementRequestContext(); + private: // Overridden from net::URLRequestContext: virtual const std::string& GetUserAgent(const GURL& url) const OVERRIDE; }; @@ -243,7 +242,7 @@ class DeviceManagementRequestContextGetter virtual ~DeviceManagementRequestContextGetter() {} private: - scoped_refptr<net::URLRequestContext> context_; + scoped_ptr<net::URLRequestContext> context_; scoped_refptr<net::URLRequestContextGetter> base_context_getter_; }; @@ -251,9 +250,9 @@ class DeviceManagementRequestContextGetter net::URLRequestContext* DeviceManagementRequestContextGetter::GetURLRequestContext() { DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO)); - if (!context_) { - context_ = new DeviceManagementRequestContext( - base_context_getter_->GetURLRequestContext()); + if (!context_.get()) { + context_.reset(new DeviceManagementRequestContext( + base_context_getter_->GetURLRequestContext())); } return context_.get(); |