diff options
| author | rsleevi@chromium.org <rsleevi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-11 16:46:36 +0000 |
|---|---|---|
| committer | rsleevi@chromium.org <rsleevi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-11 16:46:36 +0000 |
| commit | cadac62e5c2b9f5fef59ce0326bb2cd79ffbe622 (patch) | |
| tree | 7b95f103fce509de887c8c5e643604855b57c0ba /chrome/browser/policy | |
| parent | 9f6e673c7f43f6ee414f72a74585dad8ebaceec3 (diff) | |
| download | chromium_src-cadac62e5c2b9f5fef59ce0326bb2cd79ffbe622.zip chromium_src-cadac62e5c2b9f5fef59ce0326bb2cd79ffbe622.tar.gz chromium_src-cadac62e5c2b9f5fef59ce0326bb2cd79ffbe622.tar.bz2 | |
Call scoped_refptr<T>::get() rather than relying on implicit "operator T*"
This upates calls to bound temporary objects to also use get().
While it has the same semantic equivalence to the existing code, this generally
represents a dangerous pattern - indeed, part of the whole motivation for this
change is to make this anti-pattern very visible to authors.
This change simply updates all of the call sites, to allow the "operator T*"
to be removed and preventing new instances. The existing instances will then be
reviewed for "suspicious" changes and updated to use/pass scoped_refptr<T>
rather than T*, as appropriate.
BUG=110610
TBR=darin
Review URL: https://codereview.chromium.org/15984016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205560 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/policy')
| -rw-r--r-- | chrome/browser/policy/policy_browsertest.cc | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/chrome/browser/policy/policy_browsertest.cc b/chrome/browser/policy/policy_browsertest.cc index df1716b..1cf089c 100644 --- a/chrome/browser/policy/policy_browsertest.cc +++ b/chrome/browser/policy/policy_browsertest.cc @@ -1018,7 +1018,8 @@ IN_PROC_BROWSER_TEST_F(PolicyTest, DisabledPlugins) { const webkit::WebPluginInfo* flash = GetFlashPlugin(plugins); if (!flash) return; - PluginPrefs* plugin_prefs = PluginPrefs::GetForProfile(browser()->profile()); + PluginPrefs* plugin_prefs = + PluginPrefs::GetForProfile(browser()->profile()).get(); EXPECT_TRUE(plugin_prefs->IsPluginEnabled(*flash)); EXPECT_TRUE(SetPluginEnabled(plugin_prefs, flash, false)); EXPECT_FALSE(plugin_prefs->IsPluginEnabled(*flash)); @@ -1048,7 +1049,8 @@ IN_PROC_BROWSER_TEST_F(PolicyTest, DisabledPluginsExceptions) { const webkit::WebPluginInfo* flash = GetFlashPlugin(plugins); if (!flash) return; - PluginPrefs* plugin_prefs = PluginPrefs::GetForProfile(browser()->profile()); + PluginPrefs* plugin_prefs = + PluginPrefs::GetForProfile(browser()->profile()).get(); EXPECT_TRUE(plugin_prefs->IsPluginEnabled(*flash)); // Disable all plugins. @@ -1086,7 +1088,8 @@ IN_PROC_BROWSER_TEST_F(PolicyTest, EnabledPlugins) { const webkit::WebPluginInfo* flash = GetFlashPlugin(plugins); if (!flash) return; - PluginPrefs* plugin_prefs = PluginPrefs::GetForProfile(browser()->profile()); + PluginPrefs* plugin_prefs = + PluginPrefs::GetForProfile(browser()->profile()).get(); EXPECT_TRUE(plugin_prefs->IsPluginEnabled(*flash)); // The user disables it and then a policy forces it to be enabled. |