diff options
author | gab@chromium.org <gab@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-02-28 01:17:41 +0000 |
---|---|---|
committer | gab@chromium.org <gab@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-02-28 01:17:41 +0000 |
commit | c987a24655fedc08f1e04ee79e06e3f0df25d03a (patch) | |
tree | 5c1516372e1c2f6e8738c8168240c2784e2eb133 /chrome/browser/popup_blocker_browsertest.cc | |
parent | 160b8f609544fed63af64d1c24e4a70dda725e0d (diff) | |
download | chromium_src-c987a24655fedc08f1e04ee79e06e3f0df25d03a.zip chromium_src-c987a24655fedc08f1e04ee79e06e3f0df25d03a.tar.gz chromium_src-c987a24655fedc08f1e04ee79e06e3f0df25d03a.tar.bz2 |
Remove kDefaultHostDesktopType from browser_finder.cc.
This forces GetBrowserCount() and GetTabbedBrowserCount() to also take HostDesktopType; changed all consumers to provide desktop context in their query.
Introducing GetTotalBrowserCountForProfile() which is like GetBrowserCount(), but cummulative over all desktops; used in two scenarios where the caller of the old GetBrowserCount() actually wanted to know whether all browsers for a given profile were gone from the p.o.v. of the browser process (i.e. accross all desktops).
BUG=129187
Review URL: https://chromiumcodereview.appspot.com/12315094
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185092 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/popup_blocker_browsertest.cc')
-rw-r--r-- | chrome/browser/popup_blocker_browsertest.cc | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/chrome/browser/popup_blocker_browsertest.cc b/chrome/browser/popup_blocker_browsertest.cc index 151f70e..c2e3ede 100644 --- a/chrome/browser/popup_blocker_browsertest.cc +++ b/chrome/browser/popup_blocker_browsertest.cc @@ -70,7 +70,8 @@ class PopupBlockerBrowserTest : public InProcessBrowserTest { ui_test_utils::NavigateToURL(browser, url); observer.Wait(); - ASSERT_EQ(2u, chrome::GetBrowserCount(browser->profile())); + ASSERT_EQ(2u, chrome::GetBrowserCount(browser->profile(), + browser->host_desktop_type())); std::vector<WebContents*> blocked_contents = GetBlockedContents(browser); ASSERT_TRUE(blocked_contents.empty()); @@ -83,7 +84,8 @@ class PopupBlockerBrowserTest : public InProcessBrowserTest { // If the popup blocker blocked the blank post, there should be only one // tab in only one browser window and the URL of current tab must be equal // to the original URL. - EXPECT_EQ(1u, chrome::GetBrowserCount(browser->profile())); + EXPECT_EQ(1u, chrome::GetBrowserCount(browser->profile(), + browser->host_desktop_type())); EXPECT_EQ(1, browser->tab_strip_model()->count()); WebContents* web_contents = browser->tab_strip_model()->GetActiveWebContents(); |