summaryrefslogtreecommitdiffstats
path: root/chrome/browser/prerender/prerender_browsertest.cc
diff options
context:
space:
mode:
authormmenke@chromium.org <mmenke@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-09-09 19:01:31 +0000
committermmenke@chromium.org <mmenke@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-09-09 19:01:31 +0000
commit971412a4b6e6cac4fc056654853d77cb98587858 (patch)
tree5cc6fcd64f57131cbc09028c670b14a5903d67c2 /chrome/browser/prerender/prerender_browsertest.cc
parentf2eb08b3b42cf219c6cd45f6f3efeb23ee18a2a9 (diff)
downloadchromium_src-971412a4b6e6cac4fc056654853d77cb98587858.zip
chromium_src-971412a4b6e6cac4fc056654853d77cb98587858.tar.gz
chromium_src-971412a4b6e6cac4fc056654853d77cb98587858.tar.bz2
Accidentally enabled the wrong test.
Revert 100454 - Fix PrerenderBrowserTest.PrerenderInfiniteLoop flake due to process destruction/prerender contents destruction race. TEST=PrerenderBrowserTest.PrerenderInfiniteLoop BUG=83170 Review URL: http://codereview.chromium.org/7787029 TBR=mmenke@chromium.org Review URL: http://codereview.chromium.org/7862004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100457 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/prerender/prerender_browsertest.cc')
-rw-r--r--chrome/browser/prerender/prerender_browsertest.cc11
1 files changed, 3 insertions, 8 deletions
diff --git a/chrome/browser/prerender/prerender_browsertest.cc b/chrome/browser/prerender/prerender_browsertest.cc
index ceb6ec3..cdb5563 100644
--- a/chrome/browser/prerender/prerender_browsertest.cc
+++ b/chrome/browser/prerender/prerender_browsertest.cc
@@ -152,14 +152,8 @@ class TestPrerenderContents : public PrerenderContents {
// before the PrerenderManager is destroyed. As a result, it's possible to
// get either FINAL_STATUS_APP_TERMINATING or FINAL_STATUS_RENDERER_CRASHED
// on quit.
- //
- // It's also possible for this to be called after we've been notified of
- // app termination, but before we've been deleted, which is why the second
- // check is needed.
- if (expected_final_status_ == FINAL_STATUS_APP_TERMINATING &&
- final_status() != expected_final_status_) {
+ if (expected_final_status_ == FINAL_STATUS_APP_TERMINATING)
expected_final_status_ = FINAL_STATUS_RENDERER_CRASHED;
- }
PrerenderContents::RenderViewGone();
}
@@ -1095,7 +1089,8 @@ IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, PrerenderInfiniteLoop) {
// Checks that we don't prerender in an infinite loop and multiple links are
// handled correctly.
// Flaky, http://crbug.com/77323, but failing in a CHECK so disabled.
-IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest, PrerenderInfiniteLoopMultiple) {
+IN_PROC_BROWSER_TEST_F(PrerenderBrowserTest,
+ DISABLED_PrerenderInfiniteLoopMultiple) {
const char* const kHtmlFileA =
"files/prerender/prerender_infinite_a_multiple.html";
const char* const kHtmlFileB =