Assert that thread-safe reference counting is used with

cross-thread NewRunnableMethod.

This assertion caught such an error in VisitedLinkMaster!

My approach, modify RunnableMethodTraits<T> to assert that
when ReleaseCallee happens on a different thread from
RetainCallee that the type supports thread-safe reference
counting.  I do this by adding a static method to both
RefCounted<T> and RefCountedThreadSafe<T>.

This results in a little ugliness in cases where people
implement AddRef and Release by hand (to make the no-ops).
There may be a nicer way to deal with those few cases.

R=brettw
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/251012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27379 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 2 insertions, 8 deletions

diff --git a/chrome/browser/printing/print_job_unittest.cc b/chrome/browser/printing/print_job_unittest.cc
index fe98964..3ef795c 100644
--- a/chrome/browser/printing/print_job_unittest.cc
+++ b/chrome/browser/printing/print_job_unittest.cc
@@ -33,12 +33,6 @@ class TestPrintJobWorker : public printing::PrintJobWorker {
 
 class TestOwner : public printing::PrintJobWorkerOwner {
  public:
-  virtual void AddRef() {
-    EXPECT_FALSE(true);
-  }
-  virtual void Release() {
-    EXPECT_FALSE(true);
-  }
   virtual void GetSettingsDone(const printing::PrintSettings& new_settings,
                                printing::PrintingContext::Result result) {
     EXPECT_FALSE(true);
@@ -104,9 +98,9 @@ TEST(PrintJobTest, SimplePrint) {
   volatile bool check = false;
   scoped_refptr<printing::PrintJob> job(new TestPrintJob(&check));
   EXPECT_EQ(MessageLoop::current(), job->message_loop());
-  TestOwner owner;
+  scoped_refptr<TestOwner> owner(new TestOwner);
   TestSource source;
-  job->Initialize(&owner, &source);
+  job->Initialize(owner, &source);
   job->Stop();
   job = NULL;
   EXPECT_TRUE(check);