Simplify threading in browser thread by making only ChromeThread deal with different thread lifetimes.The rest of the code doesn't get MessageLoop pointers since they're not thread-safe and instead just call PostTask on ChromeThread. If the target thread is not alive, then the task is simply deleted.In a followup change, I'll remove any remaining MessageLoop* caching. With this change, there's little to be gained by caching since no locks are involved if the target MessageLoop is guaranteed to outlive the current thread (inferred automatically by the order of the chrome_threads_ array).BUG=25354

Review URL: http://codereview.chromium.org/306032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30163 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 6 insertions, 6 deletions

diff --git a/chrome/browser/printing/print_job_worker.cc b/chrome/browser/printing/print_job_worker.cc
index 27a553d..3a91f0c 100644
--- a/chrome/browser/printing/print_job_worker.cc
+++ b/chrome/browser/printing/print_job_worker.cc
@@ -77,10 +77,11 @@ void PrintJobWorker::GetSettings(bool ask_user_for_settings,
 
   if (ask_user_for_settings) {
 #if defined(OS_MACOSX)
-    ChromeThread::GetMessageLoop(ChromeThread::UI)->PostTask(
-        FROM_HERE, NewRunnableMethod(this, &PrintJobWorker::GetSettingsWithUI,
-                                     parent_window, document_page_count,
-                                     has_selection));
+    ChromeThread::PostTask(
+        ChromeThread::UI, FROM_HERE,
+        NewRunnableMethod(this, &PrintJobWorker::GetSettingsWithUI,
+                          parent_window, document_page_count,
+                          has_selection));
 #else
     PrintingContext::Result result = printing_context_.AskUserForSettings(
         parent_window, document_page_count, has_selection);
@@ -111,8 +112,7 @@ void PrintJobWorker::GetSettingsDone(PrintingContext::Result result) {
 void PrintJobWorker::GetSettingsWithUI(gfx::NativeWindow parent_window,
                                        int document_page_count,
                                        bool has_selection) {
-  DCHECK_EQ(ChromeThread::GetMessageLoop(ChromeThread::UI),
-            MessageLoop::current());
+  DCHECK(ChromeThread::CurrentlyOn(ChromeThread::UI));
 
   PrintingContext::Result result = printing_context_.AskUserForSettings(
       parent_window, document_page_count, has_selection);