summaryrefslogtreecommitdiffstats
path: root/chrome/browser/render_view_context_menu_controller.cc
diff options
context:
space:
mode:
authorpkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2008-12-11 19:20:26 +0000
committerpkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2008-12-11 19:20:26 +0000
commit1ffed9387c38f75fe7ff13ec54a3cf893005b103 (patch)
treef87bf6b3ff3fb5b746b380b3cf209df2790c1971 /chrome/browser/render_view_context_menu_controller.cc
parent1d0d8f176df9f7a9043a825541d016189754a27e (diff)
downloadchromium_src-1ffed9387c38f75fe7ff13ec54a3cf893005b103.zip
chromium_src-1ffed9387c38f75fe7ff13ec54a3cf893005b103.tar.gz
chromium_src-1ffed9387c38f75fe7ff13ec54a3cf893005b103.tar.bz2
Try and make some spellcheck code more obvious by using typedefs.
I am not convinced this patch is a net win. Please share your thoughts on if using a Language/Languages set of types is better or worse than what we're doing now. Review URL: http://codereview.chromium.org/13367 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6807 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/render_view_context_menu_controller.cc')
-rw-r--r--chrome/browser/render_view_context_menu_controller.cc12
1 files changed, 6 insertions, 6 deletions
diff --git a/chrome/browser/render_view_context_menu_controller.cc b/chrome/browser/render_view_context_menu_controller.cc
index cbcef59..186fe0b 100644
--- a/chrome/browser/render_view_context_menu_controller.cc
+++ b/chrome/browser/render_view_context_menu_controller.cc
@@ -209,9 +209,9 @@ bool RenderViewContextMenuController::IsItemChecked(int id) const {
(id >= IDC_SPELLCHECK_LANGUAGES_LAST))
return false;
- std::vector<std::wstring> display_language_vector;
+ SpellChecker::Languages display_languages;
return SpellChecker::GetSpellCheckLanguagesToDisplayInContextMenu(
- source_web_contents_->profile(), &display_language_vector) ==
+ source_web_contents_->profile(), &display_languages) ==
(id - IDC_SPELLCHECK_LANGUAGES_FIRST);
}
@@ -254,14 +254,14 @@ void RenderViewContextMenuController::ExecuteCommand(int id) {
if (id >= IDC_SPELLCHECK_LANGUAGES_FIRST &&
id < IDC_SPELLCHECK_LANGUAGES_LAST) {
const size_t language_number = id - IDC_SPELLCHECK_LANGUAGES_FIRST;
- std::vector<std::wstring> display_language_vector;
+ SpellChecker::Languages display_languages;
SpellChecker::GetSpellCheckLanguagesToDisplayInContextMenu(
- source_web_contents_->profile(), &display_language_vector);
- if (language_number < display_language_vector.size()) {
+ source_web_contents_->profile(), &display_languages);
+ if (language_number < display_languages.size()) {
StringPrefMember dictionary_language;
dictionary_language.Init(prefs::kSpellCheckDictionary,
source_web_contents_->profile()->GetPrefs(), NULL);
- dictionary_language.SetValue(display_language_vector[language_number]);
+ dictionary_language.SetValue(display_languages[language_number]);
}
return;