diff options
author | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-10-31 23:34:03 +0000 |
---|---|---|
committer | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-10-31 23:34:03 +0000 |
commit | f890108d79ed124f122b1e2526866e0e96410ff9 (patch) | |
tree | a7cb6a7e96646af30f8935d3638c20662e7cbe57 /chrome/browser/render_view_host.cc | |
parent | 8922de5133af29b6d89830f5df893b3eccf3c7c1 (diff) | |
download | chromium_src-f890108d79ed124f122b1e2526866e0e96410ff9.zip chromium_src-f890108d79ed124f122b1e2526866e0e96410ff9.tar.gz chromium_src-f890108d79ed124f122b1e2526866e0e96410ff9.tar.bz2 |
This fixes the VerifyHistoryLength ui test flakiness. The test initiates page navigations in timers and reads the history length to validate it.
When we receive a request to initiate a navigation in the browser, we send out the request to the renderer and then immediately read the history length and send it out in an update history length request. This causes the test to fail at times as it reads a stale history length.
When we receive the DidAddHistoryItem notification in the renderer, we should not update the history length for the start page navigation. This results in the test failure at times as it reads an incorrect history length.
R=jam
Review URL: http://codereview.chromium.org/8898
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4344 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/render_view_host.cc')
-rw-r--r-- | chrome/browser/render_view_host.cc | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/chrome/browser/render_view_host.cc b/chrome/browser/render_view_host.cc index db87871..08addb5 100644 --- a/chrome/browser/render_view_host.cc +++ b/chrome/browser/render_view_host.cc @@ -180,8 +180,6 @@ void RenderViewHost::NavigateToEntry(const NavigationEntry& entry, process()->host_id(), params.url); DoNavigate(new ViewMsg_Navigate(routing_id_, params)); - - UpdateBackForwardListCount(); } void RenderViewHost::NavigateToURL(const GURL& url) { |