diff options
| author | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-01-09 20:21:11 +0000 |
|---|---|---|
| committer | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-01-09 20:21:11 +0000 |
| commit | cfd727ff8ea3e853a5e2f7c39cd1902fac090ecb (patch) | |
| tree | e4f752f4fa1c3985abe91af25e7918c90a59768f /chrome/browser/render_view_host_delegate.h | |
| parent | 9b341774ce43e4034ac4465997b31e7b15fa1928 (diff) | |
| download | chromium_src-cfd727ff8ea3e853a5e2f7c39cd1902fac090ecb.zip chromium_src-cfd727ff8ea3e853a5e2f7c39cd1902fac090ecb.tar.gz chromium_src-cfd727ff8ea3e853a5e2f7c39cd1902fac090ecb.tar.bz2 | |
The popup for autofill is now never activated, even when clicked.
This allows us to hide it when the page loses focus.
(doing that previously would have caused the popup to be hidden before the click in the popup was sent to the renderer).
Most of the file changes are just renaming focus_on_show to activatable.
TEST=Open a form and make an autofill popup. Focus another window, the popup should disappear. Ensure the autofill still work properly, and the combo-box as well.
BUG=3844,5830
Review URL: http://codereview.chromium.org/17455
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7823 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/render_view_host_delegate.h')
| -rw-r--r-- | chrome/browser/render_view_host_delegate.h | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/chrome/browser/render_view_host_delegate.h b/chrome/browser/render_view_host_delegate.h index 4cb7dcc..35e8770 100644 --- a/chrome/browser/render_view_host_delegate.h +++ b/chrome/browser/render_view_host_delegate.h @@ -61,10 +61,8 @@ class RenderViewHostDelegate { // The page is trying to open a new widget (e.g. a select popup). The // widget should be created associated with the given route, but it should // not be shown yet. That should happen in response to ShowCreatedWidget. - // If |focus_on_show| is true, the focus is given to the widget when shown, - // otherwise the focus is not changed. - virtual void CreateNewWidget(int route_id, - bool focus_on_show) = 0; + // If |activatable| is false, the widget cannot be activated or get focus. + virtual void CreateNewWidget(int route_id, bool activatable) = 0; // Show a previously created page with the specified disposition and bounds. // The window is identified by the route_id passed to CreateNewWindow. |