diff options
| author | darin@google.com <darin@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-08-07 06:31:41 +0000 |
|---|---|---|
| committer | darin@google.com <darin@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-08-07 06:31:41 +0000 |
| commit | aeab4c7449f26ac71546c1419c524c0870bc155a (patch) | |
| tree | ba7549cb86473478921b14e00d5ef8e701f7c7f8 /chrome/browser/render_widget_host.cc | |
| parent | ba7f857605d7d088dff38e6ceab868dd90fc108b (diff) | |
| download | chromium_src-aeab4c7449f26ac71546c1419c524c0870bc155a.zip chromium_src-aeab4c7449f26ac71546c1419c524c0870bc155a.tar.gz chromium_src-aeab4c7449f26ac71546c1419c524c0870bc155a.tar.bz2 | |
Revised r408 such that we no longer sometimes fail MetricsServiceTest.CrashRenderers.
That test showed that we were exiting the browser process without noticing that a child process had crashed. I fixed that by simply adding a check to see if the child process is still around before initiating the normal close of the child process. This corresponds to the case where the browser decides to close a renderer.
As a result, the race for the MessageLoop to receive a Task notifying the RenderProcessHost of a crashed renderer is removed from the picture.
The bulk of this CL is just re-landing r408, which jar reviewed.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@498 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/render_widget_host.cc')
| -rw-r--r-- | chrome/browser/render_widget_host.cc | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/chrome/browser/render_widget_host.cc b/chrome/browser/render_widget_host.cc index 542f903..8f48a51 100644 --- a/chrome/browser/render_widget_host.cc +++ b/chrome/browser/render_widget_host.cc @@ -29,11 +29,8 @@ #include "chrome/browser/render_widget_host.h" -#include <atlbase.h> -#include <atlapp.h> - #include "base/gfx/bitmap_header.h" -#include "base/histogram.h" +#include "base/message_loop.h" #include "chrome/app/chrome_dll_resource.h" #include "chrome/browser/render_process_host.h" #include "chrome/browser/render_widget_helper.h" |