diff options
| author | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-08 23:35:47 +0000 |
|---|---|---|
| committer | willchan@chromium.org <willchan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-08 23:35:47 +0000 |
| commit | 0d7e79fa8ce1bef5ca6d413c908c267c35f5867a (patch) | |
| tree | 5509297bccd2e1b4c8abd0680090547c4b707f18 /chrome/browser/renderer_host/audio_renderer_host.cc | |
| parent | f94151690a90af7029a1ab6ddb0f7679af3a9c7d (diff) | |
| download | chromium_src-0d7e79fa8ce1bef5ca6d413c908c267c35f5867a.zip chromium_src-0d7e79fa8ce1bef5ca6d413c908c267c35f5867a.tar.gz chromium_src-0d7e79fa8ce1bef5ca6d413c908c267c35f5867a.tar.bz2 | |
Revert 61899 for breaking cookes on file:// URLs.
BUG=58553
=================================================
Fix instances of passing raw pointers to RefCounted objects in tasks.
Some of these manually handled it correctly by using AddRef()/Release() pairs. I switched them to make_scoped_refptr() to be more consistent. This also makes them cleanup properly on MessageLoop shutdown if we start deleting tasks.
BUG=28083
TEST=builds
Review URL: http://codereview.chromium.org/3581008
TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/3654001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62043 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/renderer_host/audio_renderer_host.cc')
| -rw-r--r-- | chrome/browser/renderer_host/audio_renderer_host.cc | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/chrome/browser/renderer_host/audio_renderer_host.cc b/chrome/browser/renderer_host/audio_renderer_host.cc index 8e0fdc5..af63515 100644 --- a/chrome/browser/renderer_host/audio_renderer_host.cc +++ b/chrome/browser/renderer_host/audio_renderer_host.cc @@ -126,7 +126,7 @@ void AudioRendererHost::OnCreated(media::AudioOutputController* controller) { NewRunnableMethod( this, &AudioRendererHost::DoCompleteCreation, - make_scoped_refptr(controller))); + controller)); } void AudioRendererHost::OnPlaying(media::AudioOutputController* controller) { @@ -136,7 +136,7 @@ void AudioRendererHost::OnPlaying(media::AudioOutputController* controller) { NewRunnableMethod( this, &AudioRendererHost::DoSendPlayingMessage, - make_scoped_refptr(controller))); + controller)); } void AudioRendererHost::OnPaused(media::AudioOutputController* controller) { @@ -146,7 +146,7 @@ void AudioRendererHost::OnPaused(media::AudioOutputController* controller) { NewRunnableMethod( this, &AudioRendererHost::DoSendPausedMessage, - make_scoped_refptr(controller))); + controller)); } void AudioRendererHost::OnError(media::AudioOutputController* controller, @@ -156,7 +156,7 @@ void AudioRendererHost::OnError(media::AudioOutputController* controller, FROM_HERE, NewRunnableMethod(this, &AudioRendererHost::DoHandleError, - make_scoped_refptr(controller), + controller, error_code)); } @@ -167,7 +167,7 @@ void AudioRendererHost::OnMoreData(media::AudioOutputController* controller, FROM_HERE, NewRunnableMethod(this, &AudioRendererHost::DoRequestMoreData, - make_scoped_refptr(controller), + controller, buffers_state)); } |