summaryrefslogtreecommitdiffstats
path: root/chrome/browser/renderer_host/render_process_host.cc
diff options
context:
space:
mode:
authorjam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-04-13 23:18:02 +0000
committerjam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-04-13 23:18:02 +0000
commit235caa47af34c2f68b26a38d46f1002e56f6cbfe (patch)
tree0c9394d1337957754d93b1a7c8ca54809f996fae /chrome/browser/renderer_host/render_process_host.cc
parente9d2f166c90ccd612c7ba014c4066840053d5bee (diff)
downloadchromium_src-235caa47af34c2f68b26a38d46f1002e56f6cbfe.zip
chromium_src-235caa47af34c2f68b26a38d46f1002e56f6cbfe.tar.gz
chromium_src-235caa47af34c2f68b26a38d46f1002e56f6cbfe.tar.bz2
Don't overload the meaning of the RENDERER_PROCESS_TERMINATED notification, instead create a new one for crashing.
The old way of using notifications was incorrect since a RenderProcessHost might have sent only one notification even though a new renderer might have been created after a crash. BUG=9379 Review URL: http://codereview.chromium.org/66069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13629 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/renderer_host/render_process_host.cc')
-rw-r--r--chrome/browser/renderer_host/render_process_host.cc12
1 files changed, 3 insertions, 9 deletions
diff --git a/chrome/browser/renderer_host/render_process_host.cc b/chrome/browser/renderer_host/render_process_host.cc
index 8cafe1e..0fdde82 100644
--- a/chrome/browser/renderer_host/render_process_host.cc
+++ b/chrome/browser/renderer_host/render_process_host.cc
@@ -65,7 +65,6 @@ bool RenderProcessHost::run_renderer_in_process_ = false;
RenderProcessHost::RenderProcessHost(Profile* profile)
: max_page_id_(-1),
- notified_termination_(false),
pid_(-1),
profile_(profile) {
}
@@ -87,14 +86,9 @@ void RenderProcessHost::Release(int listener_id) {
// When no other owners of this object, we can delete ourselves
if (listeners_.IsEmpty()) {
- if (!notified_termination_) {
- bool close_expected = true;
- NotificationService::current()->Notify(
- NotificationType::RENDERER_PROCESS_TERMINATED,
- Source<RenderProcessHost>(this),
- Details<bool>(&close_expected));
- notified_termination_ = true;
- }
+ NotificationService::current()->Notify(
+ NotificationType::RENDERER_PROCESS_TERMINATED,
+ Source<RenderProcessHost>(this), NotificationService::NoDetails());
if (pid_ >= 0) {
all_hosts.Remove(pid_);
pid_ = -1;