diff options
author | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-27 22:03:27 +0000 |
---|---|---|
committer | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-27 22:03:27 +0000 |
commit | 74da5bd311a8b8ab0c9bb189f242936a93b1b581 (patch) | |
tree | ae0d39cf9ee7ae34e09fe5c25dd15da18258fe97 /chrome/browser/renderer_host/render_view_host.h | |
parent | b0bcdbfe4b1e64fc2d07ccf3963ffb9097d6afb9 (diff) | |
download | chromium_src-74da5bd311a8b8ab0c9bb189f242936a93b1b581.zip chromium_src-74da5bd311a8b8ab0c9bb189f242936a93b1b581.tar.gz chromium_src-74da5bd311a8b8ab0c9bb189f242936a93b1b581.tar.bz2 |
Relanding this as this was reverted.
Move the handling of Desktop notification IPCs coming in from the renderer into a helper
object DesktopNotificationHandler whose lifetype is dependent on the TabContents which
instantiates it. This object implements the WebNavigationObserver interface which enables
it to handle IPCs on the UI thread.
The DeskopNotificationHandler object is also instantiated by the ExtensionHost object
as it expects the desktop notification IPC's to be handled. I also changed the desktop
notification IPCs to carry the routing id as an additional parameter as the notification
handling in the browser needs the routing id.
BUG=70690
TEST=no change in functionality.
TBR=jam
Review URL: http://codereview.chromium.org/6240015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72892 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/renderer_host/render_view_host.h')
-rw-r--r-- | chrome/browser/renderer_host/render_view_host.h | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/chrome/browser/renderer_host/render_view_host.h b/chrome/browser/renderer_host/render_view_host.h index bb49437..df00cb1 100644 --- a/chrome/browser/renderer_host/render_view_host.h +++ b/chrome/browser/renderer_host/render_view_host.h @@ -46,7 +46,6 @@ struct ViewHostMsg_DidPrintPage_Params; struct ViewHostMsg_DomMessage_Params; struct ViewHostMsg_PageHasOSDD_Type; struct ViewHostMsg_RunFileChooser_Params; -struct ViewHostMsg_ShowNotification_Params; struct ViewHostMsg_ShowPopup_Params; struct ViewMsg_Navigate_Params; struct WebApplicationInfo; @@ -616,10 +615,6 @@ class RenderViewHost : public RenderWidgetHost { void OnDevToolsRuntimePropertyChanged(const std::string& name, const std::string& value); void OnMsgShouldCloseACK(bool proceed); - void OnShowDesktopNotification( - const ViewHostMsg_ShowNotification_Params& params); - void OnCancelDesktopNotification(int notification_id); - void OnRequestNotificationPermission(const GURL& origin, int callback_id); void OnExtensionRequest(const ViewHostMsg_DomMessage_Params& params); void OnExtensionPostMessage(int port_id, const std::string& message); |