diff options
| author | rafaelw@chromium.org <rafaelw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-28 22:53:11 +0000 |
|---|---|---|
| committer | rafaelw@chromium.org <rafaelw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-28 22:53:11 +0000 |
| commit | 534c66c7338db94220b0f5995b299415d99e918e (patch) | |
| tree | af5c53e617901fa64ddd0478f133e091724c7d8f /chrome/browser/renderer_host/render_widget_helper.h | |
| parent | 121de344c56a98dcb82612b7f789d70eb646b592 (diff) | |
| download | chromium_src-534c66c7338db94220b0f5995b299415d99e918e.zip chromium_src-534c66c7338db94220b0f5995b299415d99e918e.tar.gz chromium_src-534c66c7338db94220b0f5995b299415d99e918e.tar.bz2 | |
This is the second side of a multi-sided webkit patch that will allow experimental window.open feature strings to be captured and passed to the client.
It should wait for: https://bugs.webkit.org/show_bug.cgi?id=38013 to land. This is required because this patch needs to use the WebWindowFeature binding struct in WebKit.
Once this is landed, a webkit patch to change the call signature for WebViewClient::createView to include the WebWindowFeatures will be submitted (and after that another chromium patch to remove the old call signature).
This patch implements old and new WebViewClient::createView signatures, and additionally passes the vector all the way to RenderViewHostDelegateHelper who will eventually use it to observe the 'background' feature.
BUG=41275
TEST=all tests should pass
Review URL: http://codereview.chromium.org/1758004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45877 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/renderer_host/render_widget_helper.h')
| -rw-r--r-- | chrome/browser/renderer_host/render_widget_helper.h | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/chrome/browser/renderer_host/render_widget_helper.h b/chrome/browser/renderer_host/render_widget_helper.h index 33ca744..f942903 100644 --- a/chrome/browser/renderer_host/render_widget_helper.h +++ b/chrome/browser/renderer_host/render_widget_helper.h @@ -14,6 +14,7 @@ #include "base/ref_counted.h" #include "base/lock.h" #include "base/waitable_event.h" +#include "chrome/common/window_container_type.h" #include "third_party/WebKit/WebKit/chromium/public/WebPopupType.h" namespace IPC { @@ -121,6 +122,7 @@ class RenderWidgetHelper void CreateNewWindow(int opener_id, bool user_gesture, + WindowContainerType window_container_type, base::ProcessHandle render_process, int* route_id); void CreateNewWidget(int opener_id, @@ -161,7 +163,8 @@ class RenderWidgetHelper // Called on the UI thread to finish creating a window. void OnCreateWindowOnUI(int opener_id, - int route_id); + int route_id, + WindowContainerType window_container_type); // Called on the IO thread after a window was created on the UI thread. void OnCreateWindowOnIO(int route_id); |