diff options
author | eroman@chromium.org <eroman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-02 04:53:31 +0000 |
---|---|---|
committer | eroman@chromium.org <eroman@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-02 04:53:31 +0000 |
commit | afd832cff8b5c78906b6208a3cd5d2305b17a54f (patch) | |
tree | 3e303eaa2421fcffd2fdd5c393cb280deac8bcbe /chrome/browser/renderer_host/sync_resource_handler.h | |
parent | aa6a3108baff4294383b7e8e7aaca974d99d64a5 (diff) | |
download | chromium_src-afd832cff8b5c78906b6208a3cd5d2305b17a54f.zip chromium_src-afd832cff8b5c78906b6208a3cd5d2305b17a54f.tar.gz chromium_src-afd832cff8b5c78906b6208a3cd5d2305b17a54f.tar.bz2 |
Make all of the methods of ResourceHandler pure virtual.
This forces implementations to consider each case, and avoids subtle bugs that can happen by using the default no-op implementation (like bug 36964).
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/661236
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40358 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/renderer_host/sync_resource_handler.h')
-rw-r--r-- | chrome/browser/renderer_host/sync_resource_handler.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/chrome/browser/renderer_host/sync_resource_handler.h b/chrome/browser/renderer_host/sync_resource_handler.h index d15fe0d..683dd3d 100644 --- a/chrome/browser/renderer_host/sync_resource_handler.h +++ b/chrome/browser/renderer_host/sync_resource_handler.h @@ -20,15 +20,18 @@ class SyncResourceHandler : public ResourceHandler { const GURL& url, IPC::Message* result_message); + bool OnUploadProgress(int request_id, uint64 position, uint64 size); bool OnRequestRedirected(int request_id, const GURL& new_url, ResourceResponse* response, bool* defer); bool OnResponseStarted(int request_id, ResourceResponse* response); + bool OnWillStart(int request_id, const GURL& url, bool* defer); bool OnWillRead(int request_id, net::IOBuffer** buf, int* buf_size, int min_size); bool OnReadCompleted(int request_id, int* bytes_read); bool OnResponseCompleted(int request_id, const URLRequestStatus& status, const std::string& security_info); + void OnRequestClosed(); private: enum { kReadBufSize = 3840 }; |