Remove RenderProcessHost::size(). With Pawel's change, size() isn't necessarily

correct, and it was badly named and needed fixing anyway.

This patch just removes it. There were a few debugging places that used it
which I just removed, since I think they're old and haven't been useful lately.

The non-trivial changes were in the histogram code, it now counts them slightly
differently.
Review URL: http://codereview.chromium.org/171051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23622 0039d316-1c4b-4281-b951-d872f2087c98

3 files changed, 1 insertions, 9 deletions

diff --git a/chrome/browser/renderer_host/render_process_host.cc b/chrome/browser/renderer_host/render_process_host.cc
index 4f0cbc0..bbec190 100644
--- a/chrome/browser/renderer_host/render_process_host.cc
+++ b/chrome/browser/renderer_host/render_process_host.cc
@@ -130,11 +130,6 @@ RenderProcessHost::iterator RenderProcessHost::AllHostsIterator() {
 }
 
 // static
-size_t RenderProcessHost::size() {
-  return all_hosts.size();
-}
-
-// static
 RenderProcessHost* RenderProcessHost::FromID(int render_process_id) {
   return all_hosts.Lookup(render_process_id);
 }
@@ -158,7 +153,7 @@ RenderProcessHost* RenderProcessHost::GetExistingProcessHost(Profile* profile,
                                                              Type type) {
   // First figure out which existing renderers we can use.
   std::vector<RenderProcessHost*> suitable_renderers;
-  suitable_renderers.reserve(size());
+  suitable_renderers.reserve(all_hosts.size());
 
   iterator iter(AllHostsIterator());
   while (!iter.IsAtEnd()) {
diff --git a/chrome/browser/renderer_host/render_process_host.h b/chrome/browser/renderer_host/render_process_host.h
index c906235..20b9e81 100644
--- a/chrome/browser/renderer_host/render_process_host.h
+++ b/chrome/browser/renderer_host/render_process_host.h
@@ -194,7 +194,6 @@ class RenderProcessHost : public IPC::Channel::Sender,
   // Allows iteration over all the RenderProcessHosts in the browser. Note
   // that each host may not be active, and therefore may have NULL channels.
   static iterator AllHostsIterator();
-  static size_t size();  // TODO(brettw) rename this, it's very unclear.
 
   // Returns the RenderProcessHost given its ID.  Returns NULL if the ID does
   // not correspond to a live RenderProcessHost.
diff --git a/chrome/browser/renderer_host/render_view_host.cc b/chrome/browser/renderer_host/render_view_host.cc
index 8db507e..d028db5 100644
--- a/chrome/browser/renderer_host/render_view_host.cc
+++ b/chrome/browser/renderer_host/render_view_host.cc
@@ -147,7 +147,6 @@ void RenderViewHost::Observe(NotificationType type,
   RenderProcessHost* rph = Source<RenderProcessHost>(source).ptr();
   if (rph == process()) {
     // Try to get some debugging information on the stack.
-    size_t num_hosts = RenderProcessHost::size();
     bool no_listeners = rph->ListenersIterator().IsAtEnd();
     bool live_instance = site_instance() != NULL;
     CHECK(live_instance);
@@ -156,7 +155,6 @@ void RenderViewHost::Observe(NotificationType type,
     CHECK(no_listeners);
     CHECK(live_process);
     CHECK(same_process);
-    CHECK(num_hosts > 0);
     CHECK(false) << "RenderViewHost should outlive its RenderProcessHost.";
   }
 }