summaryrefslogtreecommitdiffstats
path: root/chrome/browser/renderer_host
diff options
context:
space:
mode:
authorbrettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-01-29 23:00:43 +0000
committerbrettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-01-29 23:00:43 +0000
commitc69acd33d46f165a3838811dd7989452c85d77e5 (patch)
treeb65fcbbab14ca354d677a5d83fead74f571cce5f /chrome/browser/renderer_host
parenta2f7c2624565a8bcbc5e53e249b6d7ab7814db48 (diff)
downloadchromium_src-c69acd33d46f165a3838811dd7989452c85d77e5.zip
chromium_src-c69acd33d46f165a3838811dd7989452c85d77e5.tar.gz
chromium_src-c69acd33d46f165a3838811dd7989452c85d77e5.tar.bz2
Clean up the Windows-ness in the sizing of new views. Write a bunch of comments
about issues I discovered in this process. Review URL: http://codereview.chromium.org/19677 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8923 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/renderer_host')
-rw-r--r--chrome/browser/renderer_host/render_widget_host_view.h25
1 files changed, 12 insertions, 13 deletions
diff --git a/chrome/browser/renderer_host/render_widget_host_view.h b/chrome/browser/renderer_host/render_widget_host_view.h
index 2238773..76316b4 100644
--- a/chrome/browser/renderer_host/render_widget_host_view.h
+++ b/chrome/browser/renderer_host/render_widget_host_view.h
@@ -21,24 +21,23 @@ class RenderProcessHost;
class RenderWidgetHost;
class WebCursor;
-///////////////////////////////////////////////////////////////////////////////
-//
-// RenderWidgetHostView
-//
-// RenderWidgetHostView is an interface implemented by an object that acts as
-// the "View" portion of a RenderWidgetHost. The RenderWidgetHost and its
-// associated RenderProcessHost own the "Model" in this case which is the
-// child renderer process. The View is responsible for receiving events from
-// the surrounding environment and passing them to the RenderWidgetHost, and
-// for actually displaying the content of the RenderWidgetHost when it
-// changes.
-//
-///////////////////////////////////////////////////////////////////////////////
+// RenderWidgetHostView is an interface implemented by an object that acts as
+// the "View" portion of a RenderWidgetHost. The RenderWidgetHost and its
+// associated RenderProcessHost own the "Model" in this case which is the
+// child renderer process. The View is responsible for receiving events from
+// the surrounding environment and passing them to the RenderWidgetHost, and
+// for actually displaying the content of the RenderWidgetHost when it
+// changes.
class RenderWidgetHostView {
public:
// Platform-specific creator. Use this to construct new RenderWidgetHostViews
// rather than using RenderWidgetHostViewWin & friends.
//
+ // This function must NOT size it, because the RenderView in the renderer
+ // wounldn't have been created yet. The widget would set its "waiting for
+ // resize ack" flag, and the ack would never come becasue no RenderView
+ // received it.
+ //
// The RenderWidgetHost must already be created (because we can't know if it's
// going to be a regular RenderWidgetHost or a RenderViewHost (a subclass).
static RenderWidgetHostView* CreateViewForWidget(RenderWidgetHost* widget);