diff options
| author | rafaelw@chromium.org <rafaelw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-06 03:00:40 +0000 |
|---|---|---|
| committer | rafaelw@chromium.org <rafaelw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-05-06 03:00:40 +0000 |
| commit | e8345245dbeed71eed592c8a89e4b70403019e47 (patch) | |
| tree | 5b9e56c874df5de0cee3656c8c901a2f41f51c32 /chrome/browser/renderer_host | |
| parent | 622b74522b0ee8aa0343dd48fbbd0230e9806d5e (diff) | |
| download | chromium_src-e8345245dbeed71eed592c8a89e4b70403019e47.zip chromium_src-e8345245dbeed71eed592c8a89e4b70403019e47.tar.gz chromium_src-e8345245dbeed71eed592c8a89e4b70403019e47.tar.bz2 | |
Initial support for web-extent background pages.
This patch adds a new RVH container: BackgroundContents. The idea is that apps can open a live web-page as a "background" page using window.open('<url>', '<name>', 'background');
If 'background' is specified and the opener is within the app's extent, a BackgroundContents will be used. Otherwise, the 'background' feature is ignored and it is treated as a regular popup call.
Note that as of this patch the following are explicitly not-yet addressed:
1) Session storage for BackgroundContents
2) SSL (or other failures) requiring UI
3) Javascript messages (alert, etc...)
4) Session restore
TEST=All tests should pass
BUG=41275
Review URL: http://codereview.chromium.org/1734014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46544 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/renderer_host')
| -rw-r--r-- | chrome/browser/renderer_host/render_view_host.cc | 4 | ||||
| -rw-r--r-- | chrome/browser/renderer_host/render_view_host.h | 6 |
2 files changed, 5 insertions, 5 deletions
diff --git a/chrome/browser/renderer_host/render_view_host.cc b/chrome/browser/renderer_host/render_view_host.cc index c592b81..2dc570e 100644 --- a/chrome/browser/renderer_host/render_view_host.cc +++ b/chrome/browser/renderer_host/render_view_host.cc @@ -1263,8 +1263,8 @@ void RenderViewHost::DisassociateFromPopupCount() { Send(new ViewMsg_DisassociateFromPopupCount(routing_id())); } -void RenderViewHost::PopupNotificationVisibilityChanged(bool visible) { - Send(new ViewMsg_PopupNotificationVisibilityChanged(routing_id(), visible)); +void RenderViewHost::AllowScriptToClose(bool script_can_close) { + Send(new ViewMsg_AllowScriptToClose(routing_id(), script_can_close)); } void RenderViewHost::OnMsgGoToEntryAtOffset(int offset) { diff --git a/chrome/browser/renderer_host/render_view_host.h b/chrome/browser/renderer_host/render_view_host.h index 84dec34..0fffedd 100644 --- a/chrome/browser/renderer_host/render_view_host.h +++ b/chrome/browser/renderer_host/render_view_host.h @@ -376,9 +376,9 @@ class RenderViewHost : public RenderWidgetHost { // as a popup. void DisassociateFromPopupCount(); - // Notifies the Renderer that we've either displayed or hidden the popup - // notification. - void PopupNotificationVisibilityChanged(bool visible); + // Tells the renderer whether it should allow window.close. This is initially + // set to false when creating a renderer-initiated window via window.open. + void AllowScriptToClose(bool visible); // Called by the AutoFillManager when the list of suggestions is ready. void AutoFillSuggestionsReturned( |