diff options
| author | jar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-28 22:02:46 +0000 |
|---|---|---|
| committer | jar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-28 22:02:46 +0000 |
| commit | c9a3ef84a7d486d4dd24fe8332b8b83ed833885d (patch) | |
| tree | e1180399782984b4f1ffd909be6149c5ce1cc736 /chrome/browser/renderer_host | |
| parent | c2a44c4852ad9f800968dcc32e3344c948c2bc88 (diff) | |
| download | chromium_src-c9a3ef84a7d486d4dd24fe8332b8b83ed833885d.zip chromium_src-c9a3ef84a7d486d4dd24fe8332b8b83ed833885d.tar.gz chromium_src-c9a3ef84a7d486d4dd24fe8332b8b83ed833885d.tar.bz2 | |
Automatically adapt to faster/slower uploads of renderer histograms
This replaces the current time based approach (chrome is given N seconds
to upload all renederer histograms) with an asynch callback approach
that waits until all renderers have responded (with their updates). It
uses a fall-back timer to ensure that a hung renderer won't delay things
forever as well.
This causes faster (and complete) updates in about:histograms as well
as generally assuring complete updates during UMA gatherings.
This code was contributed by Raman Tenneti in CL 42496
http://codereview.chromium.org/42496
bug=12850
r=raman
Review URL: http://codereview.chromium.org/113473
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17123 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/renderer_host')
| -rw-r--r-- | chrome/browser/renderer_host/resource_message_filter.cc | 4 | ||||
| -rw-r--r-- | chrome/browser/renderer_host/resource_message_filter.h | 3 |
2 files changed, 5 insertions, 2 deletions
diff --git a/chrome/browser/renderer_host/resource_message_filter.cc b/chrome/browser/renderer_host/resource_message_filter.cc index 4749064..8cfaa61 100644 --- a/chrome/browser/renderer_host/resource_message_filter.cc +++ b/chrome/browser/renderer_host/resource_message_filter.cc @@ -23,6 +23,7 @@ #include "chrome/common/app_cache/app_cache_dispatcher_host.h" #include "chrome/common/chrome_plugin_lib.h" #include "chrome/common/chrome_plugin_util.h" +#include "chrome/common/histogram_synchronizer.h" #include "chrome/common/notification_service.h" #include "chrome/common/pref_names.h" #include "chrome/common/pref_service.h" @@ -832,8 +833,9 @@ void ResourceMessageFilter::OnDnsPrefetch( } void ResourceMessageFilter::OnRendererHistograms( + int sequence_number, const std::vector<std::string>& histograms) { - Histogram::DeserializeHistogramList(histograms); + HistogramSynchronizer::DeserializeHistogramList(sequence_number, histograms); } #if defined(OS_MACOSX) diff --git a/chrome/browser/renderer_host/resource_message_filter.h b/chrome/browser/renderer_host/resource_message_filter.h index bc156c7..9e23079 100644 --- a/chrome/browser/renderer_host/resource_message_filter.h +++ b/chrome/browser/renderer_host/resource_message_filter.h @@ -152,7 +152,8 @@ class ResourceMessageFilter : public IPC::ChannelProxy::MessageFilter, void OnGetAutoCorrectWord(const std::wstring& word, IPC::Message* reply_msg); void OnDnsPrefetch(const std::vector<std::string>& hostnames); - void OnRendererHistograms(const std::vector<std::string>& histogram_info); + void OnRendererHistograms(int sequence_number, + const std::vector<std::string>& histogram_info); void OnReceiveContextMenuMsg(const IPC::Message& msg); // Clipboard messages void OnClipboardWriteObjects(const Clipboard::ObjectMap& objects); |