diff options
| author | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-03 17:01:36 +0000 |
|---|---|---|
| committer | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-03 17:01:36 +0000 |
| commit | 6c6cc80b2463e75d94ebb0d392ccf54761374a64 (patch) | |
| tree | 027e484cadfabddc197efe4ccab1567bc6cb9b0f /chrome/browser/renderer_host | |
| parent | ded5e4e7e6bc7c7d4d16223929dbb0f69fc8add0 (diff) | |
| download | chromium_src-6c6cc80b2463e75d94ebb0d392ccf54761374a64.zip chromium_src-6c6cc80b2463e75d94ebb0d392ccf54761374a64.tar.gz chromium_src-6c6cc80b2463e75d94ebb0d392ccf54761374a64.tar.bz2 | |
Make OpenProcessHandle report an error when it couldn't open the handle.
One more step to land http://codereview.chromium.org/54003 (chrome_process_util).
Review URL: http://codereview.chromium.org/62004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13086 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/renderer_host')
| -rw-r--r-- | chrome/browser/renderer_host/resource_message_filter.cc | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/chrome/browser/renderer_host/resource_message_filter.cc b/chrome/browser/renderer_host/resource_message_filter.cc index 007c5fd..549fc6a 100644 --- a/chrome/browser/renderer_host/resource_message_filter.cc +++ b/chrome/browser/renderer_host/resource_message_filter.cc @@ -173,8 +173,11 @@ void ResourceMessageFilter::OnFilterAdded(IPC::Channel* channel) { // Called on the IPC thread: void ResourceMessageFilter::OnChannelConnected(int32 peer_pid) { DCHECK(!handle()); - set_handle(base::OpenProcessHandle(peer_pid)); - DCHECK(handle()); + base::ProcessHandle peer_handle; + if (!base::OpenProcessHandle(peer_pid, &peer_handle)) { + NOTREACHED(); + } + set_handle(peer_handle); // Hook AudioRendererHost to this object after channel is connected so it can // this object for sending messages. audio_renderer_host_->IPCChannelConnected(this); |