summaryrefslogtreecommitdiffstats
path: root/chrome/browser/renderer_host
diff options
context:
space:
mode:
authorpinkerton@chromium.org <pinkerton@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-03-03 14:26:54 +0000
committerpinkerton@chromium.org <pinkerton@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-03-03 14:26:54 +0000
commit7d926f9072ac496db6df715cc6a6bd5d3f9bd011 (patch)
tree5a098ba124a7d9749d43617e703d62ce9f271171 /chrome/browser/renderer_host
parentebd49b19aafad701860adf8e1e145448ef8d13e5 (diff)
downloadchromium_src-7d926f9072ac496db6df715cc6a6bd5d3f9bd011.zip
chromium_src-7d926f9072ac496db6df715cc6a6bd5d3f9bd011.tar.gz
chromium_src-7d926f9072ac496db6df715cc6a6bd5d3f9bd011.tar.bz2
Remove some instances of NOTIMPLEMENTED in favor of hooking up functionality or filing a bug as a placeholder. Reduces noise at startup.
Review URL: http://codereview.chromium.org/27353 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10790 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/renderer_host')
-rw-r--r--chrome/browser/renderer_host/render_widget_host_view_mac.mm11
1 files changed, 9 insertions, 2 deletions
diff --git a/chrome/browser/renderer_host/render_widget_host_view_mac.mm b/chrome/browser/renderer_host/render_widget_host_view_mac.mm
index b644b7a..e8d9c25 100644
--- a/chrome/browser/renderer_host/render_widget_host_view_mac.mm
+++ b/chrome/browser/renderer_host/render_widget_host_view_mac.mm
@@ -80,11 +80,18 @@ void RenderWidgetHostViewMac::SetSize(const gfx::Size& size) {
if (is_hidden_)
return;
- NOTIMPLEMENTED(); // Who is trying to force a size? We're a Cocoa view.
+ // TODO(avi): the WebContents object uses this method to size the newly
+ // created widget to the correct size. At the time of this call, we're not yet
+ // in the view hierarchy so |size| ends up being 0x0. However, this works for
+ // us because we're using the Cocoa view struture and resizer flags to fix
+ // things up as soon as the view gets added to the hierarchy. Figure out if we
+ // want to keep this flow or switch back to the flow Windows uses which sets
+ // the size upon creation. http://crbug.com/8285.
}
gfx::NativeView RenderWidgetHostViewMac::GetPluginNativeView() {
- NOTIMPLEMENTED();
+ // All plugin stuff is TBD. TODO(avi,awalker): fill in
+ // http://crbug.com/8192
return nil;
}