diff options
author | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-03 02:17:31 +0000 |
---|---|---|
committer | ananta@chromium.org <ananta@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-03 02:17:31 +0000 |
commit | 39c32782c244ad7e2793bed305bf941b24103d1f (patch) | |
tree | 927bf5f039913c68e800e24b5808da2a72d72a1c /chrome/browser/renderer_host | |
parent | 6bb27c014a169b1c34b5cc8ad45c4aad453fc779 (diff) | |
download | chromium_src-39c32782c244ad7e2793bed305bf941b24103d1f.zip chromium_src-39c32782c244ad7e2793bed305bf941b24103d1f.tar.gz chromium_src-39c32782c244ad7e2793bed305bf941b24103d1f.tar.bz2 |
Pass unhandled keyup messages coming in from the renderer to the underlying view. This is needed
for system keyboard messages which are generated when the Alt key is pressed in addition to other
keys to function correctly in ChromeFrame.
The TabContentsView implementation for windows does the right thing by specifically checking for keydown
events before processing them as accelerators. The TabContentsView implementation for Linux also treated
keyup messages as accelerators, which is now fixed.
This fixes parts of http://code.google.com/p/chromium/issues/detail?id=22996
Bug=22996
Review URL: http://codereview.chromium.org/255028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27926 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/renderer_host')
-rw-r--r-- | chrome/browser/renderer_host/render_view_host.cc | 9 |
1 files changed, 1 insertions, 8 deletions
diff --git a/chrome/browser/renderer_host/render_view_host.cc b/chrome/browser/renderer_host/render_view_host.cc index a778f62..e793a7b 100644 --- a/chrome/browser/renderer_host/render_view_host.cc +++ b/chrome/browser/renderer_host/render_view_host.cc @@ -1436,14 +1436,7 @@ void RenderViewHost::UnhandledKeyboardEvent( const NativeWebKeyboardEvent& event) { RenderViewHostDelegate::View* view = delegate_->GetViewDelegate(); if (view) { - // TODO(brettw) why do we have to filter these types of events here. Can't - // the renderer just send us the ones we care abount, or maybe the view - // should be able to decide which ones it wants or not? - if ((event.type == WebInputEvent::RawKeyDown) || - (event.type == WebInputEvent::KeyDown) || - (event.type == WebInputEvent::Char)) { - view->HandleKeyboardEvent(event); - } + view->HandleKeyboardEvent(event); } } |