diff options
| author | bryeung@google.com <bryeung@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-08 14:57:19 +0000 |
|---|---|---|
| committer | bryeung@google.com <bryeung@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-08 14:57:19 +0000 |
| commit | 546ae4e00d8d3a344d7c7587327f591dca2265bc (patch) | |
| tree | 35a47b9eccf545d381b0558957cea823140e9549 /chrome/browser/renderer_host | |
| parent | 391bb5da06453b5080bdec0b652bc5e5bf364cd6 (diff) | |
| download | chromium_src-546ae4e00d8d3a344d7c7587327f591dca2265bc.zip chromium_src-546ae4e00d8d3a344d7c7587327f591dca2265bc.tar.gz chromium_src-546ae4e00d8d3a344d7c7587327f591dca2265bc.tar.bz2 | |
Propagate is_editable_node in the FOCUS_CHANGED_IN_PAGE notification.
Also fixes up types and a bug in WindowedNotificationObserverWithDetails.
BUG=none
TEST=updated BrowserFocusTest.FocusTraversal
Review URL: http://codereview.chromium.org/5516005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68597 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/renderer_host')
| -rw-r--r-- | chrome/browser/renderer_host/render_view_host.cc | 16 | ||||
| -rw-r--r-- | chrome/browser/renderer_host/render_view_host_delegate.h | 2 |
2 files changed, 2 insertions, 16 deletions
diff --git a/chrome/browser/renderer_host/render_view_host.cc b/chrome/browser/renderer_host/render_view_host.cc index 66ad564..c9ae516 100644 --- a/chrome/browser/renderer_host/render_view_host.cc +++ b/chrome/browser/renderer_host/render_view_host.cc @@ -1844,21 +1844,7 @@ void RenderViewHost::NotifyRendererResponsive() { } void RenderViewHost::OnMsgFocusedNodeChanged(bool is_editable_node) { - delegate_->FocusedNodeChanged(); - -#if defined(TOUCH_UI) - if (is_editable_node) { - // Need to summon on-screen keyboard - // TODO(bryeung): implement this - - // The currently focused element can be placed out of the view as the screen - // is now shared by the keyboard. Hence, we tell the renderer to scroll - // until the focused element comes in view. - Send(new ViewMsg_ScrollFocusedEditableNodeIntoView(routing_id())); - } else { - // TODO(bryeung): implement this. Should hide the on-screen keyboard. - } -#endif + delegate_->FocusedNodeChanged(is_editable_node); } void RenderViewHost::OnMsgFocus() { diff --git a/chrome/browser/renderer_host/render_view_host_delegate.h b/chrome/browser/renderer_host/render_view_host_delegate.h index 02ca7ca..a566062 100644 --- a/chrome/browser/renderer_host/render_view_host_delegate.h +++ b/chrome/browser/renderer_host/render_view_host_delegate.h @@ -865,7 +865,7 @@ class RenderViewHostDelegate { virtual void DidInsertCSS() {} // A different node in the page got focused. - virtual void FocusedNodeChanged() {} + virtual void FocusedNodeChanged(bool is_editable_node) {} // Updates the minimum and maximum zoom percentages. virtual void UpdateZoomLimits(int minimum_percent, |