summaryrefslogtreecommitdiffstats
path: root/chrome/browser/resources/new_new_tab.js
diff options
context:
space:
mode:
authorarv@google.com <arv@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2009-06-24 23:59:51 +0000
committerarv@google.com <arv@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2009-06-24 23:59:51 +0000
commit1e27ccc2e890645dc24f2690bb449636aa5a04a0 (patch)
treebc73102fe5c3bfda7fa770cb9406d87e6d243135 /chrome/browser/resources/new_new_tab.js
parent55578b060daacab5d7767640114e25cc3886116f (diff)
downloadchromium_src-1e27ccc2e890645dc24f2690bb449636aa5a04a0.zip
chromium_src-1e27ccc2e890645dc24f2690bb449636aa5a04a0.tar.gz
chromium_src-1e27ccc2e890645dc24f2690bb449636aa5a04a0.tar.bz2
Make sure we keep overflow: hidden on the #most-visited element when
hidden. Also, update the height of the lower section so that content does not get clipped. BUG=15234, 15106 TEST=Hide the thumbnails on the new new tab page. There should be no way that clicking on some empty space would activate a hidden .thumbnail For the second part of this bug close 5+ tabs and check that the Recently closed section does not get clipped. Review URL: http://codereview.chromium.org/146120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19199 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/resources/new_new_tab.js')
-rw-r--r--chrome/browser/resources/new_new_tab.js7
1 files changed, 5 insertions, 2 deletions
diff --git a/chrome/browser/resources/new_new_tab.js b/chrome/browser/resources/new_new_tab.js
index 14fa721..c238b57 100644
--- a/chrome/browser/resources/new_new_tab.js
+++ b/chrome/browser/resources/new_new_tab.js
@@ -191,7 +191,10 @@ function layoutMostVisited() {
}
afterTransition(function() {
- mostVisitedElement.style.overflow = '';
+ // Only set overflow to visible if the element is shown.
+ if (opacity) {
+ mostVisitedElement.style.overflow = '';
+ }
});
logEvent('layoutMostVisited: ' + (Date.now() - d0));
@@ -545,7 +548,7 @@ function layoutLowerSections() {
var recommendationsShown = shownSections & Section.RECOMMENDATIONS;
if (recentShown || recommendationsShown) {
- lowerSectionsElement.style.height = '175px'
+ lowerSectionsElement.style.height = '198px';
lowerSectionsElement.style.opacity = '';
} else {
lowerSectionsElement.style.height = lowerSectionsElement.style.opacity = 0;