diff options
| author | cpu@chromium.org <cpu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-18 23:51:39 +0000 |
|---|---|---|
| committer | cpu@chromium.org <cpu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-18 23:51:39 +0000 |
| commit | 07203723a0165189c821fa5f2bb54e4bff122a6e (patch) | |
| tree | 68e5826667034ee804fa2807857b6542cbff489d /chrome/browser/rlz | |
| parent | 72710a1e7670fbc91c97879dba4d97fb1758c7c0 (diff) | |
| download | chromium_src-07203723a0165189c821fa5f2bb54e4bff122a6e.zip chromium_src-07203723a0165189c821fa5f2bb54e4bff122a6e.tar.gz chromium_src-07203723a0165189c821fa5f2bb54e4bff122a6e.tar.bz2 | |
Have rlz record first search event in a corner case
1- start chrome do nothing for 90+ seconds
2- close chrome
3- relaunch chrome
4- type in the omnimbox before 90 seconds
5- observe (with debuger) that first search event is not recorded
BUG=b\1812626
TEST=see bug for testing details.
Review URL: http://codereview.chromium.org/646031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39397 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/rlz')
| -rw-r--r-- | chrome/browser/rlz/rlz.cc | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/chrome/browser/rlz/rlz.cc b/chrome/browser/rlz/rlz.cc index 64c56e5..20436a7 100644 --- a/chrome/browser/rlz/rlz.cc +++ b/chrome/browser/rlz/rlz.cc @@ -257,12 +257,13 @@ class DelayedInitTask : public Task { RLZTracker::CHROME_OMNIBOX, RLZTracker::SET_TO_GOOGLE); } - // Record first user interaction with the omnibox. - if (OmniBoxUsageObserver::used()) { - RLZTracker::RecordProductEvent(RLZTracker::CHROME, - RLZTracker::CHROME_OMNIBOX, - RLZTracker::FIRST_SEARCH); - } + } + // Record first user interaction with the omnibox. We call this all the + // time but the rlz lib should ingore all but the first one. + if (OmniBoxUsageObserver::used()) { + RLZTracker::RecordProductEvent(RLZTracker::CHROME, + RLZTracker::CHROME_OMNIBOX, + RLZTracker::FIRST_SEARCH); } // Schedule the daily RLZ ping. base::Thread* thread = g_browser_process->file_thread(); |