diff options
| author | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-28 00:40:48 +0000 |
|---|---|---|
| committer | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-28 00:40:48 +0000 |
| commit | 5645d5b2b6a11836bbaf0bb112478eea20a3ff44 (patch) | |
| tree | 51d9cce19f079ee8ed9146a2a0209cf194908ac3 /chrome/browser/safe_browsing/protocol_manager.cc | |
| parent | c18f3ceb89867bb83678bd8f9b24eac0212be867 (diff) | |
| download | chromium_src-5645d5b2b6a11836bbaf0bb112478eea20a3ff44.zip chromium_src-5645d5b2b6a11836bbaf0bb112478eea20a3ff44.tar.gz chromium_src-5645d5b2b6a11836bbaf0bb112478eea20a3ff44.tar.bz2 | |
Handle additional feedback from http://codereview.chromium.org/8395038/.
-rename URLFetcherFactory to URLFetcherImplFactory
-rename GetUrl to GetURL and GetOriginalUrl to GetOriginalURL
-get rid of request_type in TestURLFetcher's constructor
BUG=98716
Review URL: http://codereview.chromium.org/8416020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107665 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/safe_browsing/protocol_manager.cc')
| -rw-r--r-- | chrome/browser/safe_browsing/protocol_manager.cc | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/chrome/browser/safe_browsing/protocol_manager.cc b/chrome/browser/safe_browsing/protocol_manager.cc index 20ae1ed..f68dd00 100644 --- a/chrome/browser/safe_browsing/protocol_manager.cc +++ b/chrome/browser/safe_browsing/protocol_manager.cc @@ -263,10 +263,10 @@ void SafeBrowsingProtocolManager::OnURLFetchComplete( } else { HandleGetHashError(Time::Now()); if (source->GetStatus().status() == net::URLRequestStatus::FAILED) { - VLOG(1) << "SafeBrowsing GetHash request for: " << source->GetUrl() + VLOG(1) << "SafeBrowsing GetHash request for: " << source->GetURL() << " failed with error: " << source->GetStatus().error(); } else { - VLOG(1) << "SafeBrowsing GetHash request for: " << source->GetUrl() + VLOG(1) << "SafeBrowsing GetHash request for: " << source->GetURL() << " failed with error: " << source->GetResponseCode(); } } @@ -297,9 +297,9 @@ void SafeBrowsingProtocolManager::OnURLFetchComplete( std::string data; source->GetResponseAsString(&data); parsed_ok = HandleServiceResponse( - source->GetUrl(), data.data(), static_cast<int>(data.length())); + source->GetURL(), data.data(), static_cast<int>(data.length())); if (!parsed_ok) { - VLOG(1) << "SafeBrowsing request for: " << source->GetUrl() + VLOG(1) << "SafeBrowsing request for: " << source->GetURL() << " failed parse."; must_back_off = true; chunk_request_urls_.clear(); @@ -338,10 +338,10 @@ void SafeBrowsingProtocolManager::OnURLFetchComplete( chunk_request_urls_.clear(); UpdateFinished(false); if (source->GetStatus().status() == net::URLRequestStatus::FAILED) { - VLOG(1) << "SafeBrowsing request for: " << source->GetUrl() + VLOG(1) << "SafeBrowsing request for: " << source->GetURL() << " failed with error: " << source->GetStatus().error(); } else { - VLOG(1) << "SafeBrowsing request for: " << source->GetUrl() + VLOG(1) << "SafeBrowsing request for: " << source->GetURL() << " failed with error: " << source->GetResponseCode(); } } |