diff options
| author | jar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-12-06 00:09:37 +0000 |
|---|---|---|
| committer | jar@chromium.org <jar@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-12-06 00:09:37 +0000 |
| commit | e8829a1981a2d9d849c377c28f9444fdefee0f44 (patch) | |
| tree | 3cfe522cf76d308dec9fca773d3f9495e12abc5e /chrome/browser/safe_browsing | |
| parent | 4f3b65a30cad88c1f1e482f7bda69ef50f8e1364 (diff) | |
| download | chromium_src-e8829a1981a2d9d849c377c28f9444fdefee0f44.zip chromium_src-e8829a1981a2d9d849c377c28f9444fdefee0f44.tar.gz chromium_src-e8829a1981a2d9d849c377c28f9444fdefee0f44.tar.bz2 | |
Use factory to create histograms, and refcounts to track lifetimes
This is CL patch 377028 by Raman Tenneti, with minor changes to
make the try-bots happier.
It is cleanup that better ensures lifetimes of histograms (making it harder
for users to abuse them).
bug=16495 (repairs leak induced by the first landing)
bug=18840 (should make leaks less possible)
tbr=raman.tenneti
Review URL: http://codereview.chromium.org/462027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33933 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/safe_browsing')
| -rw-r--r-- | chrome/browser/safe_browsing/safe_browsing_blocking_page.cc | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc index a96146ce..3f559c0 100644 --- a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc +++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc @@ -69,9 +69,11 @@ enum SafeBrowsingBlockingPageEvent { }; void RecordSafeBrowsingBlockingPageStats(SafeBrowsingBlockingPageEvent event) { - static LinearHistogram histogram("interstial.safe_browsing", 0, 2, 3); - histogram.SetFlags(kUmaTargetedHistogramFlag); - histogram.Add(event); + static scoped_refptr<Histogram> histogram = + LinearHistogram::LinearHistogramFactoryGet("interstial.safe_browsing", + 1, 2, 3); + histogram->SetFlags(kUmaTargetedHistogramFlag); + histogram->Add(event); } } // namespace |