diff options
author | asanka@chromium.org <asanka@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-30 23:32:06 +0000 |
---|---|---|
committer | asanka@chromium.org <asanka@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-30 23:32:06 +0000 |
commit | 3d833de2590e5bcddec48b51691d088afb3d84e3 (patch) | |
tree | 66337201944575e32a60e36334076b4bb2be7874 /chrome/browser/safe_browsing | |
parent | bb8f10a98c8f3a96025c47100c6473e2ce9645ad (diff) | |
download | chromium_src-3d833de2590e5bcddec48b51691d088afb3d84e3.zip chromium_src-3d833de2590e5bcddec48b51691d088afb3d84e3.tar.gz chromium_src-3d833de2590e5bcddec48b51691d088afb3d84e3.tar.bz2 |
Download filename determination refactor (1/3)
- Removes dependency on DownloadStateInfo in chrome/.
- Adds unit tests for ChromeDownloadManagerDelegate.
- Cleanup methods for filename determination in DownloadItem to eliminate setters.
BUG=78085
TEST=unit tests
Review URL: https://chromiumcodereview.appspot.com/10083010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139682 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/safe_browsing')
-rw-r--r-- | chrome/browser/safe_browsing/download_protection_service.cc | 2 | ||||
-rw-r--r-- | chrome/browser/safe_browsing/download_protection_service.h | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/chrome/browser/safe_browsing/download_protection_service.cc b/chrome/browser/safe_browsing/download_protection_service.cc index c87ae89..963ab84 100644 --- a/chrome/browser/safe_browsing/download_protection_service.cc +++ b/chrome/browser/safe_browsing/download_protection_service.cc @@ -202,7 +202,7 @@ DownloadProtectionService::DownloadInfo::FromDownloadItem( download_info.referrer_url = item.GetReferrerUrl(); download_info.total_bytes = item.GetTotalBytes(); download_info.remote_address = item.GetRemoteAddress(); - download_info.user_initiated = item.GetStateInfo().has_user_gesture; + download_info.user_initiated = item.HasUserGesture(); return download_info; } diff --git a/chrome/browser/safe_browsing/download_protection_service.h b/chrome/browser/safe_browsing/download_protection_service.h index 03d8427..07ecd4c 100644 --- a/chrome/browser/safe_browsing/download_protection_service.h +++ b/chrome/browser/safe_browsing/download_protection_service.h @@ -94,7 +94,7 @@ class DownloadProtectionService { // Returns true iff the download specified by |info| should be scanned by // CheckClientDownload() for malicious content. - bool IsSupportedDownload(const DownloadInfo& info) const; + virtual bool IsSupportedDownload(const DownloadInfo& info) const; // Display more information to the user regarding the download specified by // |info|. This method is invoked when the user requests more information |