diff options
author | mbelshe@google.com <mbelshe@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-12-13 20:48:36 +0000 |
---|---|---|
committer | mbelshe@google.com <mbelshe@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-12-13 20:48:36 +0000 |
commit | 0a30765779382fa4cd46d47dab4db0ad607e7569 (patch) | |
tree | ae593d32fc4052115c428382f451bdd110bcf460 /chrome/browser/safe_browsing | |
parent | a211dddeb82823e7bf1baa24eb9583f95db7de4e (diff) | |
download | chromium_src-0a30765779382fa4cd46d47dab4db0ad607e7569.zip chromium_src-0a30765779382fa4cd46d47dab4db0ad607e7569.tar.gz chromium_src-0a30765779382fa4cd46d47dab4db0ad607e7569.tar.bz2 |
A new shot at the old system monitor changelist.
Review URL: http://codereview.chromium.org/12883
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6974 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/safe_browsing')
-rw-r--r-- | chrome/browser/safe_browsing/safe_browsing_service.cc | 17 | ||||
-rw-r--r-- | chrome/browser/safe_browsing/safe_browsing_service.h | 10 |
2 files changed, 19 insertions, 8 deletions
diff --git a/chrome/browser/safe_browsing/safe_browsing_service.cc b/chrome/browser/safe_browsing/safe_browsing_service.cc index d60f409..fc45b94 100644 --- a/chrome/browser/safe_browsing/safe_browsing_service.cc +++ b/chrome/browser/safe_browsing/safe_browsing_service.cc @@ -12,6 +12,7 @@ #include "base/path_service.h" #include "base/string_util.h" #include "chrome/browser/browser_process.h" +#include "chrome/browser/chrome_thread.h" #include "chrome/browser/profile_manager.h" #include "chrome/browser/safe_browsing/protocol_manager.h" #include "chrome/browser/safe_browsing/safe_browsing_blocking_page.h" @@ -35,9 +36,16 @@ SafeBrowsingService::SafeBrowsingService() database_loaded_(false), update_in_progress_(false) { new_safe_browsing_ = !CommandLine().HasSwitch(switches::kUseOldSafeBrowsing); + base::SystemMonitor* monitor = base::SystemMonitor::Get(); + DCHECK(monitor); + if (monitor) + monitor->AddObserver(this); } SafeBrowsingService::~SafeBrowsingService() { + base::SystemMonitor* monitor = base::SystemMonitor::Get(); + if (monitor) + monitor->RemoveObserver(this); } // Only called on the UI thread. @@ -668,18 +676,17 @@ void SafeBrowsingService::CacheHashResults( GetDatabase()->CacheHashResults(prefixes, full_hashes); } -void SafeBrowsingService::OnSuspend() { +void SafeBrowsingService::OnSuspend(base::SystemMonitor*) { } // Tell the SafeBrowsing database not to do expensive disk operations for a few // minutes after waking up. It's quite likely that the act of resuming from a // low power state will involve much disk activity, which we don't want to // exacerbate. -void SafeBrowsingService::OnResume() { - DCHECK(MessageLoop::current() == io_loop_); +void SafeBrowsingService::OnResume(base::SystemMonitor*) { if (enabled_) { - db_thread_->message_loop()->PostTask(FROM_HERE, - NewRunnableMethod(this, &SafeBrowsingService::HandleResume)); + ChromeThread::GetMessageLoop(ChromeThread::DB)->PostTask(FROM_HERE, + NewRunnableMethod(this, &SafeBrowsingService::HandleResume)); } } diff --git a/chrome/browser/safe_browsing/safe_browsing_service.h b/chrome/browser/safe_browsing/safe_browsing_service.h index 5b02aeb4..e50e6c9 100644 --- a/chrome/browser/safe_browsing/safe_browsing_service.h +++ b/chrome/browser/safe_browsing/safe_browsing_service.h @@ -16,6 +16,7 @@ #include "base/hash_tables.h" #include "base/ref_counted.h" #include "base/scoped_ptr.h" +#include "base/system_monitor.h" #include "base/thread.h" #include "base/time.h" #include "chrome/browser/safe_browsing/safe_browsing_util.h" @@ -31,7 +32,8 @@ class SafeBrowsingProtocolManager; // Construction needs to happen on the main thread. class SafeBrowsingService - : public base::RefCountedThreadSafe<SafeBrowsingService> { + : public base::RefCountedThreadSafe<SafeBrowsingService>, + public base::SystemMonitor::PowerObserver { public: // Users of this service implement this interface to be notified // asynchronously of the result. @@ -169,10 +171,12 @@ class SafeBrowsingService // the current page is 'safe'. void LogPauseDelay(base::TimeDelta time); + // PowerObserver notifications // We defer SafeBrowsing work for a short duration when the computer comes // out of a suspend state to avoid thrashing the disk. - void OnSuspend(); - void OnResume(); + void OnPowerStateChange(base::SystemMonitor*) {}; + void OnSuspend(base::SystemMonitor*); + void OnResume(base::SystemMonitor*); bool new_safe_browsing() const { return new_safe_browsing_; } |