diff options
author | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-01 14:30:51 +0000 |
---|---|---|
committer | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-06-01 14:30:51 +0000 |
commit | a918f877c38b7a0bc684a2963fba4a4341a243e8 (patch) | |
tree | b58938b92989fa1a75e8e2b0b62c21944d4cd3bb /chrome/browser/safe_browsing | |
parent | be4d55fe8d843628223a7b40162007ab734d1402 (diff) | |
download | chromium_src-a918f877c38b7a0bc684a2963fba4a4341a243e8.zip chromium_src-a918f877c38b7a0bc684a2963fba4a4341a243e8.tar.gz chromium_src-a918f877c38b7a0bc684a2963fba4a4341a243e8.tar.bz2 |
[GTTF] Add FRIEND_TEST_ALL_PREFIXES, a FRIEND_TEST replacement
that works with all test prefixes (DISABLED, FLAKY, FAILS).
TEST=none
BUG=44549
Review URL: http://codereview.chromium.org/2439001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48634 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/safe_browsing')
-rw-r--r-- | chrome/browser/safe_browsing/bloom_filter.h | 6 | ||||
-rw-r--r-- | chrome/browser/safe_browsing/protocol_manager.h | 10 | ||||
-rw-r--r-- | chrome/browser/safe_browsing/safe_browsing_database.h | 4 |
3 files changed, 10 insertions, 10 deletions
diff --git a/chrome/browser/safe_browsing/bloom_filter.h b/chrome/browser/safe_browsing/bloom_filter.h index 2abe402..519282f 100644 --- a/chrome/browser/safe_browsing/bloom_filter.h +++ b/chrome/browser/safe_browsing/bloom_filter.h @@ -19,9 +19,9 @@ #include <vector> +#include "base/gtest_prod_util.h" #include "base/ref_counted.h" #include "chrome/browser/safe_browsing/safe_browsing_util.h" -#include "testing/gtest/include/gtest/gtest_prod.h" class FilePath; @@ -60,8 +60,8 @@ class BloomFilter : public base::RefCountedThreadSafe<BloomFilter> { private: friend class base::RefCountedThreadSafe<BloomFilter>; - FRIEND_TEST(SafeBrowsingBloomFilter, BloomFilterUse); - FRIEND_TEST(SafeBrowsingBloomFilter, BloomFilterFile); + FRIEND_TEST_ALL_PREFIXES(SafeBrowsingBloomFilter, BloomFilterUse); + FRIEND_TEST_ALL_PREFIXES(SafeBrowsingBloomFilter, BloomFilterFile); static const int kNumHashKeys = 20; static const int kFileVersion = 1; diff --git a/chrome/browser/safe_browsing/protocol_manager.h b/chrome/browser/safe_browsing/protocol_manager.h index 75201ae..1526fe5 100644 --- a/chrome/browser/safe_browsing/protocol_manager.h +++ b/chrome/browser/safe_browsing/protocol_manager.h @@ -15,6 +15,7 @@ #include <string> #include <vector> +#include "base/gtest_prod_util.h" #include "base/hash_tables.h" #include "base/scoped_ptr.h" #include "base/time.h" @@ -24,7 +25,6 @@ #include "chrome/browser/safe_browsing/safe_browsing_service.h" #include "chrome/browser/safe_browsing/safe_browsing_util.h" #include "chrome/common/net/url_fetcher.h" -#include "testing/gtest/include/gtest/gtest_prod.h" class Task; class Timer; @@ -44,10 +44,10 @@ struct hash<const URLFetcher*> { #endif class SafeBrowsingProtocolManager : public URLFetcher::Delegate { - // Testing friends: - FRIEND_TEST(SafeBrowsingProtocolManagerTest, TestBackOffTimes); - FRIEND_TEST(SafeBrowsingProtocolManagerTest, TestChunkStrings); - FRIEND_TEST(SafeBrowsingProtocolManagerTest, TestGetHashBackOffTimes); + FRIEND_TEST_ALL_PREFIXES(SafeBrowsingProtocolManagerTest, TestBackOffTimes); + FRIEND_TEST_ALL_PREFIXES(SafeBrowsingProtocolManagerTest, TestChunkStrings); + FRIEND_TEST_ALL_PREFIXES(SafeBrowsingProtocolManagerTest, + TestGetHashBackOffTimes); public: // Constructs a SafeBrowsingProtocolManager for |sb_service| that issues diff --git a/chrome/browser/safe_browsing/safe_browsing_database.h b/chrome/browser/safe_browsing/safe_browsing_database.h index 88bf58a..90723f1 100644 --- a/chrome/browser/safe_browsing/safe_browsing_database.h +++ b/chrome/browser/safe_browsing/safe_browsing_database.h @@ -11,11 +11,11 @@ #include <vector> #include "base/file_path.h" +#include "base/gtest_prod_util.h" #include "base/ref_counted.h" #include "base/scoped_ptr.h" #include "base/time.h" #include "chrome/browser/safe_browsing/safe_browsing_util.h" -#include "testing/gtest/include/gtest/gtest_prod.h" class BloomFilter; class GURL; @@ -83,7 +83,7 @@ class SafeBrowsingDatabase { typedef base::hash_map<SBPrefix, HashList> HashCache; friend class SafeBrowsingDatabaseTest; - FRIEND_TEST(SafeBrowsingDatabaseTest, HashCaching); + FRIEND_TEST_ALL_PREFIXES(SafeBrowsingDatabaseTest, HashCaching); static FilePath BloomFilterFilename(const FilePath& db_filename); |