diff options
author | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-12 23:08:10 +0000 |
---|---|---|
committer | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-10-12 23:08:10 +0000 |
commit | 9b0e63e553262024ffa72deaa8a650ee93e17e7d (patch) | |
tree | 7087b906a4335c72c45dc1491a15e7505904e9f5 /chrome/browser/search_engines/template_url_fetcher.cc | |
parent | dac271e105147a82477735f261a0b224db1f4e30 (diff) | |
download | chromium_src-9b0e63e553262024ffa72deaa8a650ee93e17e7d.zip chromium_src-9b0e63e553262024ffa72deaa8a650ee93e17e7d.tar.gz chromium_src-9b0e63e553262024ffa72deaa8a650ee93e17e7d.tar.bz2 |
Make views::Label and views::Link auto-color themselves to be readable over their background color. Unfortunately since they can't automatically determine what that backgruond color is it has to be manually set. (I suppose I could try to add some crazy hierarchy-walking code looking for views::Background objects, but that seems like a bad move.) There is also a disable switch, which I use in a few places where I couldn't figure out what the background color actually is, or where updating it is really annoying.
In theory, we might want to apply this to other controls like text buttons, but since those are usually rendered with explicit background images there's probably not a ton of win there.
This also makes some other cleanup changes like converting a few wstrings to string16s, de-inlining some class member functions, etc. Some of these were mandated by the presubmitter :/
BUG=92
TEST=Things still look OK
Review URL: http://codereview.chromium.org/8221027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105189 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/search_engines/template_url_fetcher.cc')
-rw-r--r-- | chrome/browser/search_engines/template_url_fetcher.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/browser/search_engines/template_url_fetcher.cc b/chrome/browser/search_engines/template_url_fetcher.cc index aa86952..4ce2f5c 100644 --- a/chrome/browser/search_engines/template_url_fetcher.cc +++ b/chrome/browser/search_engines/template_url_fetcher.cc @@ -254,7 +254,7 @@ void TemplateURLFetcher::RequestDelegate::AddSearchProvider() { case EXPLICIT_DEFAULT_PROVIDER: callbacks_->ConfirmSetDefaultSearchProvider(template_url_.release(), - model); + fetcher_->profile()); break; } |