diff options
author | zea@chromium.org <zea@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-11-17 15:54:29 +0000 |
---|---|---|
committer | zea@chromium.org <zea@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-11-17 15:54:29 +0000 |
commit | 3f98fd98f1cff6aa30fddf33a4db91e4dc3d86af (patch) | |
tree | 81029562515c79ac858e05e281ee2071e7af8fae /chrome/browser/search_engines/template_url_service.cc | |
parent | c2b751fae48c117978396cab4e4a017b626f6a02 (diff) | |
download | chromium_src-3f98fd98f1cff6aa30fddf33a4db91e4dc3d86af.zip chromium_src-3f98fd98f1cff6aa30fddf33a4db91e4dc3d86af.tar.gz chromium_src-3f98fd98f1cff6aa30fddf33a4db91e4dc3d86af.tar.bz2 |
[Sync] Have MergeDataAndStartSyncing return a SyncMergeResult
This will allow us to track merge statistics for datatypes. For now none of
the datatypes fill the SyncMergeResult with anything other than an error.
BUG=158576
TBR=stevet@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11365241
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168446 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/search_engines/template_url_service.cc')
-rw-r--r-- | chrome/browser/search_engines/template_url_service.cc | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/chrome/browser/search_engines/template_url_service.cc b/chrome/browser/search_engines/template_url_service.cc index 381811a..e10e5b8 100644 --- a/chrome/browser/search_engines/template_url_service.cc +++ b/chrome/browser/search_engines/template_url_service.cc @@ -1110,7 +1110,7 @@ syncer::SyncError TemplateURLService::ProcessSyncChanges( return error; } -syncer::SyncError TemplateURLService::MergeDataAndStartSyncing( +syncer::SyncMergeResult TemplateURLService::MergeDataAndStartSyncing( syncer::ModelType type, const syncer::SyncDataList& initial_sync_data, scoped_ptr<syncer::SyncChangeProcessor> sync_processor, @@ -1120,6 +1120,7 @@ syncer::SyncError TemplateURLService::MergeDataAndStartSyncing( DCHECK(!sync_processor_.get()); DCHECK(sync_processor.get()); DCHECK(sync_error_factory.get()); + syncer::SyncMergeResult merge_result(type); sync_processor_ = sync_processor.Pass(); sync_error_factory_ = sync_error_factory.Pass(); @@ -1233,17 +1234,17 @@ syncer::SyncError TemplateURLService::MergeDataAndStartSyncing( LogDuplicatesHistogram(GetTemplateURLs()); - syncer::SyncError error = - sync_processor_->ProcessSyncChanges(FROM_HERE, new_changes); - if (error.IsSet()) - return error; + merge_result.set_error( + sync_processor_->ProcessSyncChanges(FROM_HERE, new_changes)); + if (merge_result.error().IsSet()) + return merge_result; // The ACTION_DELETEs from this set are processed. Empty it so we don't try to // reuse them on the next call to MergeDataAndStartSyncing. pre_sync_deletes_.clear(); models_associated_ = true; - return syncer::SyncError(); + return merge_result; } void TemplateURLService::StopSyncing(syncer::ModelType type) { |