diff options
author | rogerta@google.com <rogerta@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-13 16:09:39 +0000 |
---|---|---|
committer | rogerta@google.com <rogerta@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-13 16:09:39 +0000 |
commit | 58b6433d5199d559185f04a49496fb7acbc8df79 (patch) | |
tree | b18c1a74f5011b16a8232c45c8abcae3b051cb7c /chrome/browser/search_engines | |
parent | 19bcbfa963214916a9cd6958fac9487b48cbd071 (diff) | |
download | chromium_src-58b6433d5199d559185f04a49496fb7acbc8df79.zip chromium_src-58b6433d5199d559185f04a49496fb7acbc8df79.tar.gz chromium_src-58b6433d5199d559185f04a49496fb7acbc8df79.tar.bz2 |
Fix for issue 51693, which was a regression from integrating the open source
version of RLZ into Chromium. Chromium should never send RLZ pings to Google,
only Google Chrome should do so.
Removing dependency from rlz chrome extenion api to RLZTracker since it is
not required.
BUG=51693
TEST=Install Chromium on a clean machine and make sure no pings are sent to
http://client1.google.com/tools/pso/ping?...
Review URL: http://codereview.chromium.org/3146007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56032 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/search_engines')
-rw-r--r-- | chrome/browser/search_engines/template_url.cc | 2 | ||||
-rw-r--r-- | chrome/browser/search_engines/template_url_model.cc | 2 | ||||
-rw-r--r-- | chrome/browser/search_engines/template_url_unittest.cc | 4 |
3 files changed, 5 insertions, 3 deletions
diff --git a/chrome/browser/search_engines/template_url.cc b/chrome/browser/search_engines/template_url.cc index 8817267..29276a6 100644 --- a/chrome/browser/search_engines/template_url.cc +++ b/chrome/browser/search_engines/template_url.cc @@ -339,7 +339,7 @@ std::string TemplateURLRef::ReplaceSearchTerms( // to happen so that we replace the RLZ template with the // empty string. (If we don't handle this case, we hit a // NOTREACHED below.) -#if defined(OS_WIN) +#if defined(OS_WIN) && defined(GOOGLE_CHROME_BUILD) std::wstring rlz_string; RLZTracker::GetAccessPointRlz(rlz_lib::CHROME_OMNIBOX, &rlz_string); if (!rlz_string.empty()) { diff --git a/chrome/browser/search_engines/template_url_model.cc b/chrome/browser/search_engines/template_url_model.cc index 12c5726..d777225 100644 --- a/chrome/browser/search_engines/template_url_model.cc +++ b/chrome/browser/search_engines/template_url_model.cc @@ -502,7 +502,7 @@ void TemplateURLModel::SetDefaultSearchProvider(const TemplateURL* url) { const TemplateURLRef* url_ref = url->url(); if (url_ref && url_ref->HasGoogleBaseURLs()) { GoogleURLTracker::RequestServerCheck(); -#if defined(OS_WIN) +#if defined(OS_WIN) && defined(GOOGLE_CHROME_BUILD) RLZTracker::RecordProductEvent(rlz_lib::CHROME, rlz_lib::CHROME_OMNIBOX, rlz_lib::SET_TO_GOOGLE); diff --git a/chrome/browser/search_engines/template_url_unittest.cc b/chrome/browser/search_engines/template_url_unittest.cc index 16eafec..05087b8 100644 --- a/chrome/browser/search_engines/template_url_unittest.cc +++ b/chrome/browser/search_engines/template_url_unittest.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. +// Copyright (c) 2006-2010 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -328,7 +328,9 @@ TEST_F(TemplateURLTest, Suggestions) { #if defined(OS_WIN) TEST_F(TemplateURLTest, RLZ) { std::wstring rlz_string; +#if defined(GOOGLE_CHROME_BUILD) RLZTracker::GetAccessPointRlz(rlz_lib::CHROME_OMNIBOX, &rlz_string); +#endif TemplateURL t_url; TemplateURLRef ref("http://bar/?{google:RLZ}{searchTerms}", 1, 2); |