diff options
| author | ziadh@chromium.org <ziadh@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-30 20:39:31 +0000 |
|---|---|---|
| committer | ziadh@chromium.org <ziadh@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-30 20:39:31 +0000 |
| commit | 1bc6c551f14f237d5d56b18afb87ea1570483c1c (patch) | |
| tree | 3a5b2c22e19d3d06d82580a88754e944d3aac7c3 /chrome/browser/search_engines | |
| parent | de1e675607fb3f8fb34f90093f3b9500cf3f2e46 (diff) | |
| download | chromium_src-1bc6c551f14f237d5d56b18afb87ea1570483c1c.zip chromium_src-1bc6c551f14f237d5d56b18afb87ea1570483c1c.tar.gz chromium_src-1bc6c551f14f237d5d56b18afb87ea1570483c1c.tar.bz2 | |
Add undeclared virtual destructors part 3
Preventative maintenance for abstract classes that do not declare virtual
destructors. Base classes that do not declare their destructors as virtual
could potentially lead to memory leaks.
These files were discovered using the -Wnon-virtual-dtor flag in g++.
r=jar
BUG=47469
Review URL: http://codereview.chromium.org/3072010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54373 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/search_engines')
| -rw-r--r-- | chrome/browser/search_engines/edit_search_engine_controller.h | 3 | ||||
| -rw-r--r-- | chrome/browser/search_engines/template_url_parser.h | 3 |
2 files changed, 6 insertions, 0 deletions
diff --git a/chrome/browser/search_engines/edit_search_engine_controller.h b/chrome/browser/search_engines/edit_search_engine_controller.h index ec6e56a..b250afe 100644 --- a/chrome/browser/search_engines/edit_search_engine_controller.h +++ b/chrome/browser/search_engines/edit_search_engine_controller.h @@ -24,6 +24,9 @@ class EditSearchEngineControllerDelegate { const std::wstring& title, const std::wstring& keyword, const std::string& url) = 0; + + protected: + virtual ~EditSearchEngineControllerDelegate() {} }; // EditSearchEngineController provides the core platform independent logic diff --git a/chrome/browser/search_engines/template_url_parser.h b/chrome/browser/search_engines/template_url_parser.h index b1b29b0..d978da5 100644 --- a/chrome/browser/search_engines/template_url_parser.h +++ b/chrome/browser/search_engines/template_url_parser.h @@ -22,6 +22,9 @@ class TemplateURLParser { // methods returns false, the parameter is not included. virtual bool KeepParameter(const std::string& key, const std::string& value) = 0; + + protected: + virtual ~ParameterFilter() {} }; // Decodes the chunk of data representing a TemplateURL. If data does // not describe a valid TemplateURL false is returned. Additionally, if the |