diff options
author | jianli@chromium.org <jianli@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-05-05 20:35:14 +0000 |
---|---|---|
committer | jianli@chromium.org <jianli@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-05-05 20:35:14 +0000 |
commit | b35b26b360b5d84d064d63440590902d4974b59d (patch) | |
tree | f0aa8b0b32ca80ad7eb5efc1f78a5dcd45899b13 /chrome/browser/sessions/session_service_unittest.cc | |
parent | 4d9160ff743804acf89a5a50a0b43c113aecc1ab (diff) | |
download | chromium_src-b35b26b360b5d84d064d63440590902d4974b59d.zip chromium_src-b35b26b360b5d84d064d63440590902d4974b59d.tar.gz chromium_src-b35b26b360b5d84d064d63440590902d4974b59d.tar.bz2 |
Browser::Type cleanup.
BUG=None
TEST=Existing tests
R=ben@chromium.org,stevenjb@chromium.org,phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/6697032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84303 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/sessions/session_service_unittest.cc')
-rw-r--r-- | chrome/browser/sessions/session_service_unittest.cc | 22 |
1 files changed, 11 insertions, 11 deletions
diff --git a/chrome/browser/sessions/session_service_unittest.cc b/chrome/browser/sessions/session_service_unittest.cc index d10548e9..0f74792 100644 --- a/chrome/browser/sessions/session_service_unittest.cc +++ b/chrome/browser/sessions/session_service_unittest.cc @@ -46,7 +46,7 @@ class SessionServiceTest : public BrowserWithTestWindowTest, SessionService* session_service = new SessionService(path_); helper_.set_service(session_service); - service()->SetWindowType(window_id, Browser::TYPE_NORMAL); + service()->SetWindowType(window_id, Browser::TYPE_TABBED); service()->SetWindowBounds(window_id, window_bounds, false); } @@ -161,7 +161,7 @@ TEST_F(SessionServiceTest, Basic) { ASSERT_EQ(0, windows[0]->selected_tab_index); ASSERT_EQ(window_id.id(), windows[0]->window_id.id()); ASSERT_EQ(1U, windows[0]->tabs.size()); - ASSERT_EQ(Browser::TYPE_NORMAL, windows[0]->type); + ASSERT_EQ(Browser::TYPE_TABBED, windows[0]->type); SessionTab* tab = windows[0]->tabs[0]; helper_.AssertTabEquals(window_id, tab_id, 0, 0, 1, *tab); @@ -271,7 +271,7 @@ TEST_F(SessionServiceTest, TwoWindows) { UpdateNavigation(window_id, tab1_id, nav1, 0, true); const gfx::Rect window2_bounds(3, 4, 5, 6); - service()->SetWindowType(window2_id, Browser::TYPE_NORMAL); + service()->SetWindowType(window2_id, Browser::TYPE_TABBED); service()->SetWindowBounds(window2_id, window2_bounds, true); helper_.PrepareTabInWindow(window2_id, tab2_id, 0, true); UpdateNavigation(window2_id, tab2_id, nav2, 0, true); @@ -323,7 +323,7 @@ TEST_F(SessionServiceTest, WindowWithNoTabsGetsPruned) { UpdateNavigation(window_id, tab1_id, nav1, 0, true); const gfx::Rect window2_bounds(3, 4, 5, 6); - service()->SetWindowType(window2_id, Browser::TYPE_NORMAL); + service()->SetWindowType(window2_id, Browser::TYPE_TABBED); service()->SetWindowBounds(window2_id, window2_bounds, false); helper_.PrepareTabInWindow(window2_id, tab2_id, 0, true); @@ -383,7 +383,7 @@ TEST_F(SessionServiceTest, WindowCloseCommittedAfterNavigate) { SessionID tab2_id; ASSERT_NE(window2_id.id(), window_id.id()); - service()->SetWindowType(window2_id, Browser::TYPE_NORMAL); + service()->SetWindowType(window2_id, Browser::TYPE_TABBED); service()->SetWindowBounds(window2_id, window_bounds, false); TabNavigation nav1(0, GURL("http://google.com"), GURL(), @@ -485,14 +485,14 @@ TEST_F(SessionServiceTest, RestorePopup) { ReadWindows(&(windows.get())); ASSERT_EQ(2U, windows->size()); - int normal_index = windows[0]->type == Browser::TYPE_NORMAL ? + int tabbed_index = windows[0]->type == Browser::TYPE_TABBED ? 0 : 1; - int popup_index = normal_index == 0 ? 1 : 0; - ASSERT_EQ(0, windows[normal_index]->selected_tab_index); - ASSERT_EQ(window_id.id(), windows[normal_index]->window_id.id()); - ASSERT_EQ(1U, windows[normal_index]->tabs.size()); + int popup_index = tabbed_index == 0 ? 1 : 0; + ASSERT_EQ(0, windows[tabbed_index]->selected_tab_index); + ASSERT_EQ(window_id.id(), windows[tabbed_index]->window_id.id()); + ASSERT_EQ(1U, windows[tabbed_index]->tabs.size()); - SessionTab* tab = windows[normal_index]->tabs[0]; + SessionTab* tab = windows[tabbed_index]->tabs[0]; helper_.AssertTabEquals(window_id, tab_id, 0, 0, 1, *tab); helper_.AssertNavigationEquals(nav1, tab->navigations[0]); |