diff options
author | davemoore@chromium.org <davemoore@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-09-20 21:54:52 +0000 |
---|---|---|
committer | davemoore@chromium.org <davemoore@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-09-20 21:54:52 +0000 |
commit | d24adc83e7de8b042739c96f37588dee5ba091b3 (patch) | |
tree | e82cf26051eb22ce33a61a3f2816c39e6135675f /chrome/browser/speech/speech_recognition_bubble.cc | |
parent | fc28c977a4969a3ff4c4e8dee98fe67ce111ed86 (diff) | |
download | chromium_src-d24adc83e7de8b042739c96f37588dee5ba091b3.zip chromium_src-d24adc83e7de8b042739c96f37588dee5ba091b3.tar.gz chromium_src-d24adc83e7de8b042739c96f37588dee5ba091b3.tar.bz2 |
Revert 224473 "Remove dependency on ui::ScaleFactor from ui/gfx"
> Remove dependency on ui::ScaleFactor from ui/gfx
>
> As part of the work to removed dependencies on ui/base from ui/gfx I have
> changed the public api to Canvas, ImageSkia, ImageSkiaRep and ImagePNGRep
> to take float scale values instead of ui::ScaleFactor.
>
> The notion of supported scale factors has been broken into 2 parts.
> ui::SetSupportedScaleFactors remains and calls the
> new ImageSkia::SetSupportedScales().
>
> The initialization of the supported scale factors has been moved from layout.h
> into ResourceBundle, and is done explicitly in tests that don't use
> ResourceBundle.
>
> BUG=103304
> R=ben@chromium.org, oshima@chromium.org, sky@chromium.org
>
> Review URL: https://codereview.chromium.org/24175004
TBR=davemoore@chromium.org
Review URL: https://codereview.chromium.org/24262008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224499 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/speech/speech_recognition_bubble.cc')
-rw-r--r-- | chrome/browser/speech/speech_recognition_bubble.cc | 20 |
1 files changed, 11 insertions, 9 deletions
diff --git a/chrome/browser/speech/speech_recognition_bubble.cc b/chrome/browser/speech/speech_recognition_bubble.cc index 2b28dd9..e93c4ec 100644 --- a/chrome/browser/speech/speech_recognition_bubble.cc +++ b/chrome/browser/speech/speech_recognition_bubble.cc @@ -95,7 +95,7 @@ SpeechRecognitionBubbleImages::SpeechRecognitionBubbleImages() { // render properly and gets vertically squished in Linux due to a bug in // Skia. Until that gets fixed we work around by taking a real copy of it // below as the copied image has the correct rowBytes and renders fine. - frame.EnsureRepsForSupportedScales(); + frame.EnsureRepsForSupportedScaleFactors(); std::vector<gfx::ImageSkiaRep> image_reps = frame.image_reps(); gfx::ImageSkia frame_copy; for (size_t i = 0; i < image_reps.size(); ++i) { @@ -103,7 +103,7 @@ SpeechRecognitionBubbleImages::SpeechRecognitionBubbleImages() { SkBitmap copy_dst; copy_src.copyTo(©_dst, SkBitmap::kARGB_8888_Config); frame_copy.AddRepresentation(gfx::ImageSkiaRep( - copy_dst, image_reps[i].scale())); + copy_dst, image_reps[i].scale_factor())); } spinner_.push_back(frame_copy); @@ -140,15 +140,16 @@ SpeechRecognitionBubbleBase::SpeechRecognitionBubbleBase( animation_step_(0), display_mode_(DISPLAY_MODE_RECORDING), web_contents_(web_contents), - scale_(1.0f) { + scale_factor_(ui::SCALE_FACTOR_NONE) { gfx::NativeView view = web_contents_ ? web_contents_->GetView()->GetNativeView() : NULL; gfx::Screen* screen = gfx::Screen::GetScreenFor(view); gfx::Display display = screen->GetDisplayNearestWindow(view); - scale_ = display.device_scale_factor(); + scale_factor_ = ui::GetScaleFactorFromScale( + display.device_scale_factor()); const gfx::ImageSkiaRep& rep = - g_images.Get().mic_empty()->GetRepresentation(scale_); + g_images.Get().mic_empty()->GetRepresentation(scale_factor_); mic_image_.reset(new SkBitmap()); mic_image_->setConfig(SkBitmap::kARGB_8888_Config, rep.pixel_width(), rep.pixel_height()); @@ -234,12 +235,13 @@ void SpeechRecognitionBubbleBase::DrawVolumeOverlay(SkCanvas* canvas, (((1.0f - volume) * (width * (kVolumeSteps + 1))) - width) / kVolumeSteps; buffer_canvas.clipRect(SkRect::MakeLTRB(0, 0, SkIntToScalar(width) - clip_right, SkIntToScalar(height))); - buffer_canvas.drawBitmap(image.GetRepresentation(scale_).sk_bitmap(), 0, 0); + buffer_canvas.drawBitmap( + image.GetRepresentation(scale_factor_).sk_bitmap(), 0, 0); buffer_canvas.restore(); SkPaint multiply_paint; multiply_paint.setXfermodeMode(SkXfermode::kModulate_Mode); buffer_canvas.drawBitmap( - g_images.Get().mic_mask()->GetRepresentation(scale_).sk_bitmap(), + g_images.Get().mic_mask()->GetRepresentation(scale_factor_).sk_bitmap(), -clip_right, 0, &multiply_paint); canvas->drawBitmap(*buffer_image_.get(), 0, 0); @@ -253,12 +255,12 @@ void SpeechRecognitionBubbleBase::SetInputVolume(float volume, // Draw the empty volume image first and the current volume image on top, // and then the noise volume image on top of both. canvas.drawBitmap( - g_images.Get().mic_empty()->GetRepresentation(scale_).sk_bitmap(), + g_images.Get().mic_empty()->GetRepresentation(scale_factor_).sk_bitmap(), 0, 0); DrawVolumeOverlay(&canvas, *g_images.Get().mic_full(), volume); DrawVolumeOverlay(&canvas, *g_images.Get().mic_noise(), noise_volume); - gfx::ImageSkia image(gfx::ImageSkiaRep(*mic_image_.get(), scale_)); + gfx::ImageSkia image(gfx::ImageSkiaRep(*mic_image_.get(), scale_factor_)); SetImage(image); } |