diff options
| author | tommyw@chromium.org <tommyw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-09-03 13:39:33 +0000 |
|---|---|---|
| committer | tommyw@chromium.org <tommyw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-09-03 13:39:33 +0000 |
| commit | 70b466807ed1cd0ff8c0e390453b907975fc5a8a (patch) | |
| tree | 7d6a38b0d9af16ffd5afc5b914cdbbbce6884629 /chrome/browser/speech | |
| parent | 0b9ff7ccd6741171fef8e7bdbbd6f35de9a3e251 (diff) | |
| download | chromium_src-70b466807ed1cd0ff8c0e390453b907975fc5a8a.zip chromium_src-70b466807ed1cd0ff8c0e390453b907975fc5a8a.tar.gz chromium_src-70b466807ed1cd0ff8c0e390453b907975fc5a8a.tar.bz2 | |
WebSpeech: Protect the thread switching code from bubble changes
Changing two DCHECKs to just if cases. These DCHECKs will be hit
if the user very quickly opens and then closes the bubble.
BUG=262606
Review URL: https://chromiumcodereview.appspot.com/23403005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220936 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/speech')
| -rw-r--r-- | chrome/browser/speech/speech_recognition_bubble_controller.cc | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/chrome/browser/speech/speech_recognition_bubble_controller.cc b/chrome/browser/speech/speech_recognition_bubble_controller.cc index 32c361d..7d8e20e 100644 --- a/chrome/browser/speech/speech_recognition_bubble_controller.cc +++ b/chrome/browser/speech/speech_recognition_bubble_controller.cc @@ -115,14 +115,14 @@ void SpeechRecognitionBubbleController::InfoBubbleFocusChanged() { void SpeechRecognitionBubbleController::InvokeDelegateButtonClicked( SpeechRecognitionBubble::Button button) { DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO)); - DCHECK_NE(kInvalidSessionId, current_bubble_session_id_); - delegate_->InfoBubbleButtonClicked(current_bubble_session_id_, button); + if (kInvalidSessionId != current_bubble_session_id_) + delegate_->InfoBubbleButtonClicked(current_bubble_session_id_, button); } void SpeechRecognitionBubbleController::InvokeDelegateFocusChanged() { DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO)); - DCHECK_NE(kInvalidSessionId, current_bubble_session_id_); - delegate_->InfoBubbleFocusChanged(current_bubble_session_id_); + if (kInvalidSessionId != current_bubble_session_id_) + delegate_->InfoBubbleFocusChanged(current_bubble_session_id_); } void SpeechRecognitionBubbleController::ProcessRequestInUiThread( |