diff options
author | jar@google.com <jar@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-08-14 01:51:34 +0000 |
---|---|---|
committer | jar@google.com <jar@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2008-08-14 01:51:34 +0000 |
commit | 71e8a4492241d922f05a57cb86287f389277a243 (patch) | |
tree | c7e74df8aab3f14474598b16403d9049fd7f8a67 /chrome/browser/spellchecker.h | |
parent | 44cd16fcc85697b5094250a89decaab5c692b392 (diff) | |
download | chromium_src-71e8a4492241d922f05a57cb86287f389277a243.zip chromium_src-71e8a4492241d922f05a57cb86287f389277a243.tar.gz chromium_src-71e8a4492241d922f05a57cb86287f389277a243.tar.bz2 |
Cleanup spell check file to stop using reference counted pointers without need.
I don't really believe this will solve anything (in terms
of the bug), but it did remove some needless complexity
above the crash site in the stack. There is a tiny chance
that there is a shutdown race, where the destruction of the
containing object raced ahead of the execution (and
resulting destruction) of a task. I think the destruction
of the task by the containing object would probably be
bad anyway, and I doubt that it even happens... so this
is all about being cleaner.
bug=1318039
r=brettw
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@850 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/spellchecker.h')
-rw-r--r-- | chrome/browser/spellchecker.h | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/chrome/browser/spellchecker.h b/chrome/browser/spellchecker.h index 00bedcf..08ea018 100644 --- a/chrome/browser/spellchecker.h +++ b/chrome/browser/spellchecker.h @@ -30,9 +30,10 @@ #ifndef CHROME_BROWSER_SPELLCHECKER_H__ #define CHROME_BROWSER_SPELLCHECKER_H__ +#include <vector> + #include "chrome/browser/spellcheck_worditerator.h" -#include "base/ref_counted.h" #include "base/task.h" #include "unicode/uscript.h" @@ -150,11 +151,6 @@ class SpellChecker : public base::RefCountedThreadSafe<SpellChecker> { // Set when the dictionary file is currently downloading. bool dic_is_downloading_; - // Tasks generated in spellchecker in IO thread, to be run back in the IO - // thread from the UI thread when corresponding file is not downloading. - scoped_ptr<Task> aff_task_; - scoped_ptr<Task> dic_task_; - // Used for generating callbacks to spellchecker, since spellchecker is a // non-reference counted object. The callback is generated by generating tasks // using NewRunableMethod on these objects. |